Skip to content

Commit 8aa2176

Browse files
committed
Do not attempt to contact disconnected nodes in rabbit_nodes:list_running/1
As this will force erlang to attempt to set up a distribution connection to the down node. This can take some time, especially in cloud environments.
1 parent ac9c943 commit 8aa2176

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

deps/rabbit/src/rabbit_nodes.erl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -366,9 +366,10 @@ filter_not_running(Nodes) ->
366366
do_filter_running(Members) ->
367367
%% All clustered members where `rabbit' is running, regardless if they are
368368
%% under maintenance or not.
369+
ReachableMembers = do_filter_reachable(Members),
369370
Rets = erpc:multicall(
370-
Members, rabbit, is_running, [], ?FILTER_RPC_TIMEOUT),
371-
RetPerMember = lists:zip(Members, Rets),
371+
ReachableMembers, rabbit, is_running, [], ?FILTER_RPC_TIMEOUT),
372+
RetPerMember = lists:zip(ReachableMembers, Rets),
372373
lists:filtermap(
373374
fun
374375
({Member, {ok, true}}) ->

0 commit comments

Comments
 (0)