Skip to content

Commit 8f7b78c

Browse files
Improve queue index migration
A failure to locate source directory should be logged as an error into both upgrade and regular log for extra visibility. See https://groups.google.com/forum/#!topic/rabbitmq-users/toq2dpocm0k for background.
1 parent c5df441 commit 8f7b78c

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/rabbit_queue_index.erl

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1472,14 +1472,18 @@ move_to_per_vhost_stores(#resource{} = QueueName) ->
14721472
OldQueueDir = filename:join([queues_base_dir(), "queues",
14731473
queue_name_to_dir_name_legacy(QueueName)]),
14741474
NewQueueDir = queue_dir(QueueName),
1475+
rabbit_log_upgrade:info("About to migrate queue directory '~s' to '~s'",
1476+
[OldQueueDir, NewQueueDir]),
14751477
case rabbit_file:is_dir(OldQueueDir) of
14761478
true ->
14771479
ok = rabbit_file:ensure_dir(NewQueueDir),
14781480
ok = rabbit_file:rename(OldQueueDir, NewQueueDir),
14791481
ok = ensure_queue_name_stub_file(NewQueueDir, QueueName);
14801482
false ->
1481-
rabbit_log:info("Queue index directory not found for queue ~p~n",
1482-
[QueueName])
1483+
Msg = "Queue index directory '~s' not found for ~s~n",
1484+
Args = [OldQueueDir, rabbit_misc:rs(QueueName)],
1485+
rabbit_log_upgrade:error(Msg, Args),
1486+
rabbit_log:error(Msg, Args)
14831487
end,
14841488
ok.
14851489

0 commit comments

Comments
 (0)