Skip to content

Commit 94c8f01

Browse files
rabbitmq-diagnostics status: handle output of 3.13.x and previously released 4.0.x nodes
In a mixed cluster environment, 'rabbitmq-diagnostics status' can hit a node that does not return any node tags. Be more defensive and handle such cases by simply displaying "(none)" for such values.
1 parent 3d35416 commit 94c8f01

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

deps/rabbitmq_cli/lib/rabbitmq/cli/ctl/commands/status_command.ex

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -141,13 +141,15 @@ defmodule RabbitMQ.CLI.Ctl.Commands.StatusCommand do
141141
xs -> alarm_lines(xs, node_name)
142142
end
143143

144+
IO.inspect(m[:tags])
144145
tags_section =
145146
[
146147
"\n#{bright("Tags")}\n"
147148
] ++
148149
case m[:tags] do
149-
[] -> ["(none)"]
150-
xs -> tag_lines(xs)
150+
nil -> ["(none)"]
151+
[] -> ["(none)"]
152+
xs -> tag_lines(xs)
151153
end
152154

153155
breakdown = compute_relative_values(m[:memory])
@@ -274,7 +276,7 @@ defmodule RabbitMQ.CLI.Ctl.Commands.StatusCommand do
274276
disk_free: Keyword.get(result, :disk_free),
275277
file_descriptors: Enum.into(Keyword.get(result, :file_descriptors), %{}),
276278
alarms: Keyword.get(result, :alarms),
277-
tags: Keyword.get(result, :tags),
279+
tags: Keyword.get(result, :tags, []),
278280
listeners: listener_maps(Keyword.get(result, :listeners, [])),
279281
memory: Keyword.get(result, :memory) |> Enum.into(%{}),
280282
data_directory: Keyword.get(result, :data_directory) |> to_string,

0 commit comments

Comments
 (0)