Fix OTP-27 Dialyzer errors in rabbit

Author: lhoguin

deps/rabbit/src/rabbit_channel_tracking.erl

@@ -126,7 +126,7 @@ unregister_tracked_by_pid(ChPid) when node(ChPid) == node() ->
     case ets:lookup(?TRACKED_CHANNEL_TABLE, ChPid) of
         []     -> ok;
         [#tracked_channel{username = Username}] ->
-            ets:update_counter(?TRACKED_CHANNEL_TABLE_PER_USER, Username, -1),
+            _ = ets:update_counter(?TRACKED_CHANNEL_TABLE_PER_USER, Username, -1),
             ets:delete(?TRACKED_CHANNEL_TABLE, ChPid)
     end.
 
@@ -139,7 +139,7 @@ unregister_tracked(ChId = {Node, _Name}) when Node == node() ->
     case get_tracked_channel_by_id(ChId) of
         []     -> ok;
         [#tracked_channel{pid = ChPid, username = Username}] ->
-            ets:update_counter(?TRACKED_CHANNEL_TABLE_PER_USER, Username, -1),
+            _ = ets:update_counter(?TRACKED_CHANNEL_TABLE_PER_USER, Username, -1),
             ets:delete(?TRACKED_CHANNEL_TABLE, ChPid)
     end.
 

deps/rabbit/src/rabbit_connection_tracking.erl

@@ -151,8 +151,8 @@ unregister_tracked(ConnId = {Node, _Name}) when Node =:= node() ->
     case ets:lookup(?TRACKED_CONNECTION_TABLE, ConnId) of
         []     -> ok;
         [#tracked_connection{vhost = VHost, username = Username}] ->
-            ets:update_counter(?TRACKED_CONNECTION_TABLE_PER_USER, Username, -1),
-            ets:update_counter(?TRACKED_CONNECTION_TABLE_PER_VHOST, VHost, -1),
+            _ = ets:update_counter(?TRACKED_CONNECTION_TABLE_PER_USER, Username, -1),
+            _ = ets:update_counter(?TRACKED_CONNECTION_TABLE_PER_VHOST, VHost, -1),
             ets:delete(?TRACKED_CONNECTION_TABLE, ConnId)
     end.
 

deps/rabbit/src/rabbit_msg_store.erl

@@ -1050,7 +1050,7 @@ internal_sync(State = #msstate { current_file_handle = CurHdl,
 flying_write(Key, #msstate { flying_ets = FlyingEts }) ->
     case ets:lookup(FlyingEts, Key) of
         [{_, ?FLYING_WRITE}] ->
-            ets:update_counter(FlyingEts, Key, ?FLYING_WRITE_DONE),
+            _ = ets:update_counter(FlyingEts, Key, ?FLYING_WRITE_DONE),
             %% We only remove the object if it hasn't changed
             %% (a remove may be sent while we were processing the write).
             true = ets:delete_object(FlyingEts, {Key, ?FLYING_IS_WRITTEN}),
@@ -1318,7 +1318,7 @@ update_msg_cache(CacheEts, MsgId, Msg) ->
             %% but without the debug log that we don't want as the update is
             %% more likely to fail following recent reworkings.
             try
-                ets:update_counter(CacheEts, MsgId, {3, +1}),
+                _ = ets:update_counter(CacheEts, MsgId, {3, +1}),
                 ok
             catch error:badarg ->
                 %% The entry must have been removed between

deps/rabbit/src/rabbit_time_travel_dbg.erl

@@ -28,7 +28,7 @@ start(Pid, Apps) ->
     TracerPid = spawn_link(?MODULE, init, []),
     {ok, _} = dbg:tracer(process, {fun (Msg, _) -> TracerPid ! Msg end, []}),
     _ = [dbg:tpl(M, []) || M <- Mods],
-    dbg:p(Pid, [c]),
+    _ = dbg:p(Pid, [c]),
     ok.
 
 apps_to_mods([], Acc) ->