Skip to content

Commit c364f9e

Browse files
gerhardmichaelklishin
gerhard
authored and
michaelklishin
committed
Test RABBITMQ_var vs var behaviour when using rabbitmq-env.conf
Covers the following variables: * RABBITMQ_SCHEDULER_BIND_TYPE & SCHEDULER_BIND_TYPE * RABBITMQ_DISTRIBUTION_BUFFER_SIZE & DISTRIBUTION_BUFFER_SIZE * RABBITMQ_MAX_NUMBER_OF_PROCESSES & MAX_NUMBER_OF_PROCESSES * RABBITMQ_MAX_NUMBER_OF_ATOMS & MAX_NUMBER_OF_ATOMS (cherry picked from commit 118b448)
1 parent 846984d commit c364f9e

File tree

2 files changed

+132
-43
lines changed

2 files changed

+132
-43
lines changed

‎scripts/rabbitmq-env

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -82,23 +82,23 @@ ESCRIPT_DIR="${RABBITMQ_HOME}/escript"
8282
[ -f ${RABBITMQ_CONF_ENV_FILE} ] && . ${RABBITMQ_CONF_ENV_FILE} || true
8383

8484
DEFAULT_SCHEDULER_BIND_TYPE="db"
85-
[ "x" = "x$RABBITMQ_SCHEDULER_BIND_TYPE" ] && RABBITMQ_SCHEDULER_BIND_TYPE="$SCHEDULER_BIND_TYPE"
86-
[ "x" = "x$RABBITMQ_SCHEDULER_BIND_TYPE" ] && RABBITMQ_SCHEDULER_BIND_TYPE="$DEFAULT_SCHEDULER_BIND_TYPE"
85+
[ -n "$SCHEDULER_BIND_TYPE" ] || SCHEDULER_BIND_TYPE="$DEFAULT_SCHEDULER_BIND_TYPE"
86+
[ -n "$RABBITMQ_SCHEDULER_BIND_TYPE" ] || RABBITMQ_SCHEDULER_BIND_TYPE="$SCHEDULER_BIND_TYPE"
8787

88-
DEFAULT_DISTRIBUTION_BUFFER_SIZE=128000
89-
[ "x" = "x$RABBITMQ_DISTRIBUTION_BUFFER_SIZE" ] && RABBITMQ_DISTRIBUTION_BUFFER_SIZE="$DISTRIBUTION_BUFFER_SIZE"
90-
[ "x" = "x$RABBITMQ_DISTRIBUTION_BUFFER_SIZE" ] && RABBITMQ_DISTRIBUTION_BUFFER_SIZE="$DEFAULT_DISTRIBUTION_BUFFER_SIZE"
88+
DEFAULT_DISTRIBUTION_BUFFER_SIZE=1280000
89+
[ -n "$DISTRIBUTION_BUFFER_SIZE" ] || DISTRIBUTION_BUFFER_SIZE="$DEFAULT_DISTRIBUTION_BUFFER_SIZE"
90+
[ -n "$RABBITMQ_DISTRIBUTION_BUFFER_SIZE" ] || RABBITMQ_DISTRIBUTION_BUFFER_SIZE="$DISTRIBUTION_BUFFER_SIZE"
9191

92-
DEFAULT_MAX_NUMBER_OF_PROCESSES=1048576
93-
[ "x" = "x$RABBITMQ_MAX_NUMBER_OF_PROCESSES" ] && RABBITMQ_MAX_NUMBER_OF_PROCESSES="$MAX_NUMBER_OF_PROCESSES"
94-
[ "x" = "x$RABBITMQ_MAX_NUMBER_OF_PROCESSES" ] && RABBITMQ_MAX_NUMBER_OF_PROCESSES="$DEFAULT_MAX_NUMBER_OF_PROCESSES"
92+
DEFAULT_MAX_NUMBER_OF_PROCESSES=10485760
93+
[ -n "$MAX_NUMBER_OF_PROCESSES" ] || MAX_NUMBER_OF_PROCESSES="$DEFAULT_MAX_NUMBER_OF_PROCESSES"
94+
[ -n "$RABBITMQ_MAX_NUMBER_OF_PROCESSES" ] || RABBITMQ_MAX_NUMBER_OF_PROCESSES="$MAX_NUMBER_OF_PROCESSES"
9595

9696
DEFAULT_MAX_NUMBER_OF_ATOMS=5000000
97-
[ "x" = "x$RABBITMQ_MAX_NUMBER_OF_ATOMS" ] && RABBITMQ_MAX_NUMBER_OF_ATOMS="$MAX_NUMBER_OF_ATOMS"
98-
[ "x" = "x$RABBITMQ_MAX_NUMBER_OF_ATOMS" ] && RABBITMQ_MAX_NUMBER_OF_ATOMS="$DEFAULT_MAX_NUMBER_OF_ATOMS"
97+
[ -n "$MAX_NUMBER_OF_ATOMS" ] || MAX_NUMBER_OF_ATOMS="$DEFAULT_MAX_NUMBER_OF_ATOMS"
98+
[ -n "$RABBITMQ_MAX_NUMBER_OF_ATOMS" ] || RABBITMQ_MAX_NUMBER_OF_ATOMS="$MAX_NUMBER_OF_ATOMS"
9999

100100
## Common server defaults
101-
SERVER_ERL_ARGS="+P $RABBITMQ_MAX_NUMBER_OF_PROCESSES +t $RABBITMQ_MAX_NUMBER_OF_ATOMS +stbt $RABBITMQ_SCHEDULER_BIND_TYPE +zdbbl $RABBITMQ_DISTRIBUTION_BUFFER_SIZE"
101+
SERVER_ERL_ARGS=" +P $RABBITMQ_MAX_NUMBER_OF_PROCESSES +t $RABBITMQ_MAX_NUMBER_OF_ATOMS +stbt $RABBITMQ_SCHEDULER_BIND_TYPE +zdbbl $RABBITMQ_DISTRIBUTION_BUFFER_SIZE "
102102

103103
# We save the current value of $RABBITMQ_PID_FILE in case it was set by
104104
# an init script. If $CONF_ENV_FILE overrides it again, we must ignore

‎test/rabbitmq-env.bats

Lines changed: 121 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,128 @@
1-
@test "can configure RABBITMQ_SCHEDULER_BIND_TYPE" {
2-
declare -r scripts_dir="$BATS_TEST_DIRNAME/../scripts"
3-
export RABBITMQ_SCRIPTS_DIR="$scripts_dir"
4-
export RABBITMQ_CONF_ENV_FILE="$BATS_TMPDIR/rabbitmq-env.conf"
1+
#!/usr/bin/env bats
2+
3+
export RABBITMQ_SCRIPTS_DIR="$BATS_TEST_DIRNAME/../scripts"
4+
5+
setup() {
6+
export RABBITMQ_CONF_ENV_FILE="$BATS_TMPDIR/rabbitmq-env.$BATS_TEST_NAME.conf"
7+
}
8+
9+
@test "default Erlang scheduler bind type" {
10+
source "$RABBITMQ_SCRIPTS_DIR/rabbitmq-env"
11+
echo $RABBITMQ_SCHEDULER_BIND_TYPE
12+
13+
echo "expected RABBITMQ_SERVER_ERL_ARGS to contain ' +stbt db ', but got: $RABBITMQ_SERVER_ERL_ARGS"
14+
[[ $RABBITMQ_SERVER_ERL_ARGS == *" +stbt db "* ]]
15+
}
16+
17+
@test "can configure Erlang scheduler bind type via conf file" {
518
echo 'SCHEDULER_BIND_TYPE=u' > "$RABBITMQ_CONF_ENV_FILE"
6-
source "$scripts_dir/rabbitmq-env"
7-
echo "expected RABBITMQ_SERVER_ERL_ARGS to contain '+stbt u', but got: $RABBITMQ_SERVER_ERL_ARGS"
8-
[[ $RABBITMQ_SERVER_ERL_ARGS == *+stbt\ u* ]]
19+
source "$RABBITMQ_SCRIPTS_DIR/rabbitmq-env"
20+
21+
echo "expected RABBITMQ_SERVER_ERL_ARGS to contain ' +stbt u ', but got: $RABBITMQ_SERVER_ERL_ARGS"
22+
[[ $RABBITMQ_SERVER_ERL_ARGS == *" +stbt u "* ]]
23+
}
24+
25+
@test "can configure Erlang scheduler bind type via env" {
26+
RABBITMQ_SCHEDULER_BIND_TYPE=tnnps source "$RABBITMQ_SCRIPTS_DIR/rabbitmq-env"
27+
28+
echo "expected RABBITMQ_SERVER_ERL_ARGS to contain ' +stbt tnnps ', but got: $RABBITMQ_SERVER_ERL_ARGS"
29+
[[ $RABBITMQ_SERVER_ERL_ARGS == *" +stbt tnnps "* ]]
30+
}
31+
32+
@test "Erlang scheduler bind type env takes precedence over conf file" {
33+
echo 'SCHEDULER_BIND_TYPE=s' > "$RABBITMQ_CONF_ENV_FILE"
34+
RABBITMQ_SCHEDULER_BIND_TYPE=nnps source "$RABBITMQ_SCRIPTS_DIR/rabbitmq-env"
35+
36+
echo "expected RABBITMQ_SERVER_ERL_ARGS to contain ' +stbt nnps ', but got: $RABBITMQ_SERVER_ERL_ARGS"
37+
[[ $RABBITMQ_SERVER_ERL_ARGS == *" +stbt nnps "* ]]
38+
}
39+
40+
@test "default Erlang distribution buffer size" {
41+
source "$RABBITMQ_SCRIPTS_DIR/rabbitmq-env"
42+
43+
echo "expected RABBITMQ_SERVER_ERL_ARGS to contain ' +zdbbl 1280000 ', but got: $RABBITMQ_SERVER_ERL_ARGS"
44+
[[ $RABBITMQ_SERVER_ERL_ARGS == *" +zdbbl 1280000 "* ]]
45+
}
46+
47+
@test "can configure Erlang distribution buffer size via conf file" {
48+
echo 'DISTRIBUTION_BUFFER_SIZE=1000000' > "$RABBITMQ_CONF_ENV_FILE"
49+
source "$RABBITMQ_SCRIPTS_DIR/rabbitmq-env"
50+
51+
echo "expected RABBITMQ_SERVER_ERL_ARGS to contain ' +zdbbl 1000000 ', but got: $RABBITMQ_SERVER_ERL_ARGS"
52+
[[ $RABBITMQ_SERVER_ERL_ARGS == *" +zdbbl 1000000 "* ]]
53+
}
54+
55+
@test "can configure Erlang distribution buffer size via env" {
56+
RABBITMQ_DISTRIBUTION_BUFFER_SIZE=2000000 source "$RABBITMQ_SCRIPTS_DIR/rabbitmq-env"
57+
58+
echo "expected RABBITMQ_SERVER_ERL_ARGS to contain ' +zdbbl 2000000 ', but got: $RABBITMQ_SERVER_ERL_ARGS"
59+
[[ $RABBITMQ_SERVER_ERL_ARGS == *" +zdbbl 2000000 "* ]]
960
}
1061

11-
@test "can configure RABBITMQ_DISTRIBUTION_BUFFER_SIZE" {
12-
declare -r scripts_dir="$BATS_TEST_DIRNAME/../scripts"
13-
export RABBITMQ_SCRIPTS_DIR="$scripts_dir"
14-
export RABBITMQ_CONF_ENV_FILE="$BATS_TMPDIR/rabbitmq-env.conf"
15-
echo 'DISTRIBUTION_BUFFER_SIZE=123456' > "$RABBITMQ_CONF_ENV_FILE"
16-
source "$scripts_dir/rabbitmq-env"
17-
echo "expected RABBITMQ_SERVER_ERL_ARGS to contain '+zdbbl 123456', but got: $RABBITMQ_SERVER_ERL_ARGS"
18-
[[ $RABBITMQ_SERVER_ERL_ARGS == *+zdbbl\ 123456* ]]
62+
@test "Erlang distribution buffer size env takes precedence over conf file" {
63+
echo 'DISTRIBUTION_BUFFER_SIZE=3000000' > "$RABBITMQ_CONF_ENV_FILE"
64+
RABBITMQ_DISTRIBUTION_BUFFER_SIZE=4000000 source "$RABBITMQ_SCRIPTS_DIR/rabbitmq-env"
65+
66+
echo "expected RABBITMQ_SERVER_ERL_ARGS to contain ' +zdbbl 4000000 ', but got: $RABBITMQ_SERVER_ERL_ARGS"
67+
[[ $RABBITMQ_SERVER_ERL_ARGS == *" +zdbbl 4000000 "* ]]
68+
}
69+
70+
@test "default Erlang maximum number of processes" {
71+
source "$RABBITMQ_SCRIPTS_DIR/rabbitmq-env"
72+
73+
echo "expected RABBITMQ_SERVER_ERL_ARGS to contain ' +P 10485760 ', but got: $RABBITMQ_SERVER_ERL_ARGS"
74+
[[ $RABBITMQ_SERVER_ERL_ARGS == *" +P 10485760 "* ]]
1975
}
2076

21-
@test "can configure RABBITMQ_MAX_NUMBER_OF_PROCESSES" {
22-
declare -r scripts_dir="$BATS_TEST_DIRNAME/../scripts"
23-
export RABBITMQ_SCRIPTS_DIR="$scripts_dir"
24-
export RABBITMQ_CONF_ENV_FILE="$BATS_TMPDIR/rabbitmq-env.conf"
77+
@test "can configure Erlang maximum number of processes via conf file" {
2578
echo 'MAX_NUMBER_OF_PROCESSES=2000000' > "$RABBITMQ_CONF_ENV_FILE"
26-
source "$scripts_dir/rabbitmq-env"
27-
echo "expected RABBITMQ_SERVER_ERL_ARGS to contain '+P 2000000', but got: $RABBITMQ_SERVER_ERL_ARGS"
28-
[[ $RABBITMQ_SERVER_ERL_ARGS == *+P\ 2000000* ]]
29-
}
30-
31-
@test "can configure RABBITMQ_MAX_NUMBER_OF_ATOMS" {
32-
declare -r scripts_dir="$BATS_TEST_DIRNAME/../scripts"
33-
export RABBITMQ_SCRIPTS_DIR="$scripts_dir"
34-
export RABBITMQ_CONF_ENV_FILE="$BATS_TMPDIR/rabbitmq-env.conf"
35-
echo 'MAX_NUMBER_OF_ATOMS=10000000' > "$RABBITMQ_CONF_ENV_FILE"
36-
source "$scripts_dir/rabbitmq-env"
37-
echo "expected RABBITMQ_SERVER_ERL_ARGS to contain '+t 10000000', but got: $RABBITMQ_SERVER_ERL_ARGS"
38-
[[ $RABBITMQ_SERVER_ERL_ARGS == *+t\ 10000000* ]]
79+
source "$RABBITMQ_SCRIPTS_DIR/rabbitmq-env"
80+
81+
echo "expected RABBITMQ_SERVER_ERL_ARGS to contain ' +P 2000000 ', but got: $RABBITMQ_SERVER_ERL_ARGS"
82+
[[ $RABBITMQ_SERVER_ERL_ARGS == *" +P 2000000 "* ]]
83+
}
84+
85+
@test "can configure Erlang maximum number of processes via env" {
86+
RABBITMQ_MAX_NUMBER_OF_PROCESSES=3000000 source "$RABBITMQ_SCRIPTS_DIR/rabbitmq-env"
87+
88+
echo "expected RABBITMQ_SERVER_ERL_ARGS to contain ' +P 3000000 ', but got: $RABBITMQ_SERVER_ERL_ARGS"
89+
[[ $RABBITMQ_SERVER_ERL_ARGS == *" +P 3000000 "* ]]
90+
}
91+
92+
@test "Erlang maximum number of processes env takes precedence over conf file" {
93+
echo 'MAX_NUMBER_OF_PROCESSES=4000000' > "$RABBITMQ_CONF_ENV_FILE"
94+
RABBITMQ_MAX_NUMBER_OF_PROCESSES=5000000 source "$RABBITMQ_SCRIPTS_DIR/rabbitmq-env"
95+
96+
echo "expected RABBITMQ_SERVER_ERL_ARGS to contain ' +P 5000000 ', but got: $RABBITMQ_SERVER_ERL_ARGS"
97+
[[ $RABBITMQ_SERVER_ERL_ARGS == *" +P 5000000 "* ]]
98+
}
99+
100+
@test "default Erlang maximum number of atoms" {
101+
source "$RABBITMQ_SCRIPTS_DIR/rabbitmq-env"
102+
103+
echo "expected RABBITMQ_SERVER_ERL_ARGS to contain ' +t 5000000 ', but got: $RABBITMQ_SERVER_ERL_ARGS"
104+
[[ $RABBITMQ_SERVER_ERL_ARGS == *" +t 5000000 "* ]]
105+
}
106+
107+
@test "can configure Erlang maximum number of atoms via conf file" {
108+
echo 'MAX_NUMBER_OF_ATOMS=1000000' > "$RABBITMQ_CONF_ENV_FILE"
109+
source "$RABBITMQ_SCRIPTS_DIR/rabbitmq-env"
110+
111+
echo "expected RABBITMQ_SERVER_ERL_ARGS to contain ' +t 1000000 ', but got: $RABBITMQ_SERVER_ERL_ARGS"
112+
[[ $RABBITMQ_SERVER_ERL_ARGS == *" +t 1000000 "* ]]
113+
}
114+
115+
@test "can configure Erlang maximum number of atoms via env" {
116+
RABBITMQ_MAX_NUMBER_OF_ATOMS=2000000 source "$RABBITMQ_SCRIPTS_DIR/rabbitmq-env"
117+
118+
echo "expected RABBITMQ_SERVER_ERL_ARGS to contain ' +t 2000000 ', but got: $RABBITMQ_SERVER_ERL_ARGS"
119+
[[ $RABBITMQ_SERVER_ERL_ARGS == *" +t 2000000 "* ]]
120+
}
121+
122+
@test "Erlang maximum number of atoms env takes precedence over conf file" {
123+
echo 'MAX_NUMBER_OF_ATOMS=3000000' > "$RABBITMQ_CONF_ENV_FILE"
124+
RABBITMQ_MAX_NUMBER_OF_ATOMS=4000000 source "$RABBITMQ_SCRIPTS_DIR/rabbitmq-env"
125+
126+
echo "expected RABBITMQ_SERVER_ERL_ARGS to contain ' +t 4000000 ', but got: $RABBITMQ_SERVER_ERL_ARGS"
127+
[[ $RABBITMQ_SERVER_ERL_ARGS == *" +t 4000000 "* ]]
39128
}

0 commit comments

Comments
 (0)