Merge pull request #4708 from rabbitmq/mergify/bp/v3.9.x/pr-4707

Remove leftover compiler option for get_stacktrace (backport #4706) (backport #4707)

Author: michaelklishin

deps/rabbit/src/rabbit_channel.erl

@@ -7,10 +7,6 @@
 
 -module(rabbit_channel).
 
-%% Transitional step until we can require Erlang/OTP 21 and
-%% use the now recommended try/catch syntax for obtaining the stack trace.
--compile(nowarn_deprecated_function).
-
 %% rabbit_channel processes represent an AMQP 0-9-1 channels.
 %%
 %% Connections parse protocol frames coming from clients and

deps/rabbit/src/rabbit_node_monitor.erl

@@ -7,10 +7,6 @@
 
 -module(rabbit_node_monitor).
 
-%% Transitional step until we can require Erlang/OTP 21 and
-%% use the now recommended try/catch syntax for obtaining the stack trace.
--compile(nowarn_deprecated_function).
-
 -behaviour(gen_server).
 
 -export([start_link/0]).

deps/rabbit/src/rabbit_reader.erl

@@ -6,11 +6,6 @@
 %%
 
 -module(rabbit_reader).
-
-%% Transitional step until we can require Erlang/OTP 21 and
-%% use the now recommended try/catch syntax for obtaining the stack trace.
--compile(nowarn_deprecated_function).
-
 %% This is an AMQP 0-9-1 connection implementation. If AMQP 1.0 plugin is enabled,
 %% this module passes control of incoming AMQP 1.0 connections to it.
 %%

deps/rabbit/src/rabbit_vhost_process.erl

@@ -21,10 +21,6 @@
 
 -module(rabbit_vhost_process).
 
-%% Transitional step until we can require Erlang/OTP 21 and
-%% use the now recommended try/catch syntax for obtaining the stack trace.
--compile(nowarn_deprecated_function).
-
 -include_lib("rabbit_common/include/rabbit.hrl").
 
 -define(TICKTIME_RATIO, 4).

deps/rabbitmq_amqp1_0/include/rabbit_amqp1_0.hrl

@@ -13,9 +13,9 @@
 -define(SAFE(F),
         ((fun() ->
                   try F
-                  catch __T:__E ->
+                  catch __T:__E:__ST ->
                           io:format("~p:~p thrown debugging~n~p~n",
-                                    [__T, __E, erlang:get_stacktrace()])
+                                    [__T, __E, __ST])
                   end
           end)())).
 

deps/rabbitmq_amqp1_0/src/rabbit_amqp1_0_reader.erl

@@ -7,10 +7,6 @@
 
 -module(rabbit_amqp1_0_reader).
 
-%% Transitional step until we can require Erlang/OTP 21 and
-%% use the now recommended try/catch syntax for obtaining the stack trace.
--compile(nowarn_deprecated_function).
-
 -include_lib("rabbit_common/include/rabbit.hrl").
 -include_lib("rabbit_common/include/rabbit_framing.hrl").
 -include_lib("kernel/include/inet.hrl").

deps/rabbitmq_amqp1_0/src/rabbit_amqp1_0_session_process.erl

@@ -7,10 +7,6 @@
 
 -module(rabbit_amqp1_0_session_process).
 
-%% Transitional step until we can require Erlang/OTP 21 and
-%% use the now recommended try/catch syntax for obtaining the stack trace.
--compile(nowarn_deprecated_function).
-
 -behaviour(gen_server2).
 
 -export([init/1, terminate/2, code_change/3,

deps/rabbitmq_auth_backend_oauth2/src/uaa_jwt_jwt.erl

@@ -6,10 +6,6 @@
 %%
 -module(uaa_jwt_jwt).
 
-%% Transitional step until we can require Erlang/OTP 21 and
-%% use the now recommended try/catch syntax for obtaining the stack trace.
--compile(nowarn_deprecated_function).
-
 -export([decode/1, decode_and_verify/2, get_key_id/1]).
 
 -include_lib("jose/include/jose_jwt.hrl").

deps/rabbitmq_management_agent/src/rabbit_mgmt_external_stats.erl

@@ -7,10 +7,6 @@
 
 -module(rabbit_mgmt_external_stats).
 
-%% Transitional step until we can require Erlang/OTP 21 and
-%% use the now recommended try/catch syntax for obtaining the stack trace.
--compile(nowarn_deprecated_function).
-
 -behaviour(gen_server).
 
 -export([start_link/0]).

deps/rabbitmq_mqtt/src/rabbit_mqtt_reader.erl

@@ -7,10 +7,6 @@
 
 -module(rabbit_mqtt_reader).
 
-%% Transitional step until we can require Erlang/OTP 21 and
-%% use the now recommended try/catch syntax for obtaining the stack trace.
--compile(nowarn_deprecated_function).
-
 -behaviour(gen_server2).
 
 -export([start_link/2]).

deps/rabbitmq_trust_store/src/rabbit_trust_store.erl

@@ -7,10 +7,6 @@
 
 -module(rabbit_trust_store).
 
-%% Transitional step until we can require Erlang/OTP 21 and
-%% use the now recommended try/catch syntax for obtaining the stack trace.
--compile(nowarn_deprecated_function).
-
 -behaviour(gen_server).
 
 -export([mode/0, refresh/0, list/0]). %% Console Interface.