Rename erlang_lock_retries to internal_lock_retries

since we don't want to expose implementation details to the configuration
names.

ag erlang_lock_retries --ignore logs -l | xargs sed -I '' -e 's/erlang_lock_retries/internal_lock_retries/g'

Author: ansd

deps/rabbit/priv/schema/rabbit.schema

@@ -970,7 +970,7 @@ end}.
 %%
 %% Currently used in classic, k8s, and aws peer discovery backends.
 
-{mapping, "cluster_formation.erlang_lock_retries", "rabbit.cluster_formation.erlang_lock_retries",
+{mapping, "cluster_formation.internal_lock_retries", "rabbit.cluster_formation.internal_lock_retries",
     [
      {datatype, integer},
      {validators, ["non_zero_positive_integer"]}

deps/rabbit/src/rabbit_peer_discovery_classic_config.erl

@@ -39,7 +39,7 @@ lock(Node) ->
   LockId = {rabbit_nodes:cookie_hash(), Node},
   Retries = case application:get_env(rabbit, cluster_formation) of
               {ok, PropList} ->
-                proplists:get_value(erlang_lock_retries, PropList, ?DEFAULT_LOCK_RETRIES);
+                proplists:get_value(internal_lock_retries, PropList, ?DEFAULT_LOCK_RETRIES);
               undefined ->
                 ?DEFAULT_LOCK_RETRIES
             end,

deps/rabbit/test/config_schema_SUITE_data/rabbit.snippets

@@ -553,9 +553,9 @@ tcp_listen_options.exit_on_close = false",
   [],
   []},
 
- {cluster_formation_erlang_lock_retries,
-  "cluster_formation.erlang_lock_retries = 10",
-  [{rabbit,[{cluster_formation,[{erlang_lock_retries,10}]}]}],
+ {cluster_formation_internal_lock_retries,
+  "cluster_formation.internal_lock_retries = 10",
+  [{rabbit,[{cluster_formation,[{internal_lock_retries,10}]}]}],
   []},
 
  {cluster_formation_dns,

deps/rabbit/test/peer_discovery_classic_config_SUITE.erl

@@ -69,7 +69,7 @@ init_per_testcase(successful_discovery = Testcase, Config) ->
       {rabbit, [
           {cluster_nodes, {NodeNamesWithHostname, disc}},
           {cluster_formation, [
-              {erlang_lock_retries, 10}
+              {internal_lock_retries, 10}
           ]}
       ]}),
     rabbit_ct_helpers:run_steps(Config3,
@@ -100,7 +100,7 @@ init_per_testcase(successful_discovery_with_a_subset_of_nodes_coming_online = Te
           ]},
           {cluster_nodes, {NodeNamesWithHostname, disc}},
           {cluster_formation, [
-              {erlang_lock_retries, 10}
+              {internal_lock_retries, 10}
           ]}
       ]}),
     rabbit_ct_helpers:run_steps(Config3,
@@ -117,7 +117,7 @@ init_per_testcase(no_nodes_configured = Testcase, Config) ->
       {rabbit, [
           {cluster_nodes, {[], disc}},
           {cluster_formation, [
-              {erlang_lock_retries, 10}
+              {internal_lock_retries, 10}
           ]}
       ]}),
     rabbit_ct_helpers:run_steps(Config3,

deps/rabbitmq_peer_discovery_aws/test/unit_SUITE.erl

@@ -81,7 +81,7 @@ lock_single_node(_Config) ->
   ?assertEqual(ok, rabbit_peer_discovery_aws:unlock(LockId)).
 
 lock_multiple_nodes(_Config) ->
-  application:set_env(rabbit, cluster_formation, [{erlang_lock_retries, 2}]),
+  application:set_env(rabbit, cluster_formation, [{internal_lock_retries, 2}]),
   LocalNode = node(),
   OtherNode = other@host,
   meck:expect(rabbit_peer_discovery_aws, list_nodes, 0, {ok, {[OtherNode, LocalNode], disc}}),

deps/rabbitmq_peer_discovery_common/src/rabbit_peer_discovery_util.erl

@@ -437,7 +437,7 @@ lock_id(Node) ->
 lock_retries() ->
   case application:get_env(rabbit, cluster_formation) of
       {ok, PropList} ->
-        proplists:get_value(erlang_lock_retries, PropList, ?DEFAULT_LOCK_RETRIES);
+        proplists:get_value(internal_lock_retries, PropList, ?DEFAULT_LOCK_RETRIES);
       undefined ->
           ?DEFAULT_LOCK_RETRIES
   end.

deps/rabbitmq_peer_discovery_k8s/test/rabbitmq_peer_discovery_k8s_SUITE.erl

@@ -151,7 +151,7 @@ lock_single_node(_Config) ->
   ?assertEqual(ok, rabbit_peer_discovery_k8s:unlock(LockId)).
 
 lock_multiple_nodes(_Config) ->
-  application:set_env(rabbit, cluster_formation, [{erlang_lock_retries, 2}]),
+  application:set_env(rabbit, cluster_formation, [{internal_lock_retries, 2}]),
   LocalNode = node(),
   OtherNode = other@host,
   meck:expect(rabbit_peer_discovery_k8s, list_nodes1, 0, {ok, [OtherNode, LocalNode]}),