Skip to content

Commit f80cd7d

Browse files
committed
rabbit_db_queue: Remove unused set_many/1
This function was only used by classic mirrored queue code which was removed in 3bbda5b.
1 parent 7121b80 commit f80cd7d

File tree

2 files changed

+0
-65
lines changed

2 files changed

+0
-65
lines changed

deps/rabbit/src/rabbit_db_queue.erl

Lines changed: 0 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
count/1,
2626
create_or_get/1,
2727
set/1,
28-
set_many/1,
2928
delete/2,
3029
update/2,
3130
update_decorators/2,
@@ -962,52 +961,6 @@ set_in_khepri(Q) ->
962961
Path = khepri_queue_path(amqqueue:get_name(Q)),
963962
rabbit_khepri:put(Path, Q).
964963

965-
%% -------------------------------------------------------------------
966-
%% set_many().
967-
%% -------------------------------------------------------------------
968-
969-
-spec set_many([Queue]) -> ok when
970-
Queue :: amqqueue:amqqueue().
971-
%% @doc Writes a list of durable queue records.
972-
%%
973-
%% It is responsibility of the calling function to ensure all records are
974-
%% durable.
975-
%%
976-
%% @private
977-
978-
set_many(Qs) ->
979-
rabbit_khepri:handle_fallback(
980-
#{mnesia => fun() -> set_many_in_mnesia(Qs) end,
981-
khepri => fun() -> set_many_in_khepri(Qs) end
982-
}).
983-
984-
set_many_in_mnesia(Qs) ->
985-
{atomic, ok} =
986-
%% Just to be nested in forget_node_for_queue
987-
mnesia:transaction(
988-
fun() ->
989-
[begin
990-
true = amqqueue:is_durable(Q),
991-
ok = mnesia:write(?MNESIA_DURABLE_TABLE, Q, write)
992-
end || Q <- Qs],
993-
ok
994-
end),
995-
ok.
996-
997-
set_many_in_khepri(Qs) ->
998-
rabbit_khepri:transaction(
999-
fun() ->
1000-
[begin
1001-
true = amqqueue:is_durable(Q),
1002-
Path = khepri_queue_path(amqqueue:get_name(Q)),
1003-
case khepri_tx:put(Path, Q) of
1004-
ok -> ok;
1005-
Error -> khepri_tx:abort(Error)
1006-
end
1007-
end || Q <- Qs]
1008-
end),
1009-
ok.
1010-
1011964
%% -------------------------------------------------------------------
1012965
%% delete_transient().
1013966
%% -------------------------------------------------------------------

deps/rabbit/test/rabbit_db_queue_SUITE.erl

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ all_tests() ->
4040
count,
4141
count_by_vhost,
4242
set,
43-
set_many,
4443
delete,
4544
update,
4645
exists,
@@ -282,23 +281,6 @@ set1(_Config) ->
282281
?assertEqual({ok, Q}, rabbit_db_queue:get(QName)),
283282
passed.
284283

285-
set_many(Config) ->
286-
passed = rabbit_ct_broker_helpers:rpc(Config, 0, ?MODULE, set_many1, [Config]).
287-
288-
set_many1(_Config) ->
289-
QName1 = rabbit_misc:r(?VHOST, queue, <<"test-queue1">>),
290-
QName2 = rabbit_misc:r(?VHOST, queue, <<"test-queue2">>),
291-
QName3 = rabbit_misc:r(?VHOST, queue, <<"test-queue3">>),
292-
Q1 = new_queue(QName1, rabbit_classic_queue),
293-
Q2 = new_queue(QName2, rabbit_classic_queue),
294-
Q3 = new_queue(QName3, rabbit_classic_queue),
295-
?assertEqual(ok, rabbit_db_queue:set_many([])),
296-
?assertEqual(ok, rabbit_db_queue:set_many([Q1, Q2, Q3])),
297-
?assertEqual({ok, Q1}, rabbit_db_queue:get_durable(QName1)),
298-
?assertEqual({ok, Q2}, rabbit_db_queue:get_durable(QName2)),
299-
?assertEqual({ok, Q3}, rabbit_db_queue:get_durable(QName3)),
300-
passed.
301-
302284
delete(Config) ->
303285
passed = rabbit_ct_broker_helpers:rpc(Config, 0, ?MODULE, delete1, [Config]).
304286

0 commit comments

Comments
 (0)