Skip to content

Commit f9eda8d

Browse files
authored
Merge pull request #3300 from rabbitmq/comment-why-logging-burst-limit-is-disabled
Logging: Add comments explaining when burst limit is disabled
2 parents 85d5db6 + d0b7a33 commit f9eda8d

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

deps/rabbit/src/rabbit_prelaunch_logging.erl

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -302,6 +302,8 @@ set_log_level(Level) ->
302302
(Filter) ->
303303
Filter
304304
end, Filters),
305+
%% If the log level is set to `debug', we turn off burst limit to
306+
%% make sure all debug messages make it.
305307
Config1 = adjust_burst_limit(Config, Level),
306308
logger:set_handler_config(Id, filters, Filters1),
307309
logger:set_handler_config(Id, config, Config1),
@@ -312,6 +314,8 @@ set_log_level(Level) ->
312314
"Logging: changing '~s' handler log level to ~s",
313315
[Id, Level],
314316
#{domain => ?RMQLOG_DOMAIN_GLOBAL}),
317+
%% If the log level is set to `debug', we turn off burst limit to
318+
%% make sure all debug messages make it.
315319
Config1 = adjust_burst_limit(Config, Level),
316320
logger:set_handler_config(Id, config, Config1),
317321
logger:set_handler_config(Id, level, Level),
@@ -1419,6 +1423,9 @@ filter_log_event(LogEvent, FilterConfig) ->
14191423
%%
14201424
%% If a filter is more permissive, we need to adapt the handler log level so
14211425
%% the message makes it to the filter.
1426+
%%
1427+
%% Also, if the log level is set to `debug', we turn off burst limit to make
1428+
%% sure all debug messages make it.
14221429

14231430
adjust_log_levels(Handlers) ->
14241431
maps:map(

0 commit comments

Comments
 (0)