Skip to content

Commit fd9f6e2

Browse files
committed
Remove max-in-memory-* in Management UI
Remove quorum queue arguments and quorum queue policies (x-)max-in-memory-length and (x-)max-in-memory-bytes from the Management UI since they are deprecated since RabbitMQ 3.10. They have no effect anymore since message bodies will not be stored in memory. (cherry picked from commit 1be49d7)
1 parent 485be13 commit fd9f6e2

File tree

3 files changed

+4
-20
lines changed

3 files changed

+4
-20
lines changed

deps/rabbitmq_management/priv/www/js/global.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -197,12 +197,6 @@ var HELP = {
197197
'queue-max-length-bytes':
198198
'Total body size for ready messages a queue can contain before it starts to drop them from its head.<br/>(Sets the "<a target="_blank" href="https://rabbitmq.com/maxlength.html">x-max-length-bytes</a>" argument.)',
199199

200-
'queue-max-in-memory-length':
201-
'How many (ready) messages a quorum queue can contain in memory before it starts storing them on disk only.<br/>(Sets the x-max-in-memory-length argument.)',
202-
203-
'queue-max-in-memory-bytes':
204-
'Total body size for ready messages a quorum queue can contain in memory before it starts storing them on disk only.<br/>(Sets the x-max-in-memory-bytes argument.)',
205-
206200
'queue-max-age':
207201
'How long a message published to a stream queue can live before it is discarded.',
208202

deps/rabbitmq_management/priv/www/js/tmpl/policies.ejs

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -123,18 +123,14 @@
123123
<tr>
124124
<td>Queues [Quorum]</td>
125125
<td>
126-
<span class="argument-link" field="definition" key="max-in-memory-length" type="number">Max in memory length</span>
127-
<span class="help" id="queue-max-in-memory-length"></span> |
128-
<span class="argument-link" field="definition" key="max-in-memory-bytes" type="number">Max in memory bytes</span>
129-
<span class="help" id="queue-max-in-memory-bytes"></span> |
130126
<span class="argument-link" field="definition" key="delivery-limit" type="number">Delivery limit</span>
131-
<span class="help" id="delivery-limit"></span></br>
127+
<span class="help" id="delivery-limit"></span> |
132128
<span class="argument-link" field="definition" key="dead-letter-strategy" type="string">Dead letter strategy</span>
133129
<span class="help" id="queue-dead-letter-strategy"></span>
134130
</td>
135131
</tr>
136132
<tr>
137-
<td>Queues [Stream]</td>
133+
<td>Streams</td>
138134
<td>
139135
<span class="argument-link" field="definition" key="max-age" type="string">Max age</span>
140136
<span class="help" id="queue-max-age"></span> |
@@ -287,10 +283,6 @@
287283
<tr>
288284
<td>Queues [Quorum]</td>
289285
<td>
290-
<span class="argument-link" field="definitionop" key="max-in-memory-length" type="number">Max in memory length</span>
291-
<span class="help" id="queue-max-in-memory-length"></span> |
292-
<span class="argument-link" field="definitionop" key="max-in-memory-bytes" type="number">Max in memory bytes</span>
293-
<span class="help" id="queue-max-in-memory-bytes"></span> |
294286
<span class="argument-link" field="definitionop" key="delivery-limit" type="string">Delivery limit</span>
295287
<span class="help" id="delivery-limit"></span>
296288
</td>

deps/rabbitmq_management/priv/www/js/tmpl/queues.ejs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -330,10 +330,8 @@
330330
<% } %>
331331
<% if (queue_type == "quorum") { %>
332332
<span class="argument-link" field="arguments" key="x-delivery-limit" type="number">Delivery limit</span><span class="help" id="delivery-limit"></span>
333-
| <span class="argument-link" field="arguments" key="x-max-in-memory-length" type="number">Max in memory length</span><span class="help" id="queue-max-in-memory-length"></span>
334-
| <span class="argument-link" field="arguments" key="x-max-in-memory-bytes" type="number">Max in memory bytes</span><span class="help" id="queue-max-in-memory-bytes"></span>
335-
| <span class="argument-link" field="arguments" key="x-quorum-initial-group-size" type="number">Initial cluster size</span><span class="help" id="queue-initial-cluster-size"></span><br/>
336-
<span class="argument-link" field="arguments" key="x-dead-letter-strategy" type="string">Dead letter strategy</span><span class="help" id="queue-dead-letter-strategy"></span><br/>
333+
| <span class="argument-link" field="arguments" key="x-quorum-initial-group-size" type="number">Initial cluster size</span><span class="help" id="queue-initial-cluster-size"></span>
334+
| <span class="argument-link" field="arguments" key="x-dead-letter-strategy" type="string">Dead letter strategy</span><span class="help" id="queue-dead-letter-strategy"></span><br/>
337335
<% } %>
338336
<% if (queue_type == "stream") { %>
339337
<span class="argument-link" field="arguments" key="x-max-age" type="string">Max time retention</span><span class="help" id="queue-max-age"></span>

0 commit comments

Comments
 (0)