Skip to content

Use 3.12.6 for the secondary umbrella #8341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 22, 2023
Merged

Use 3.12.6 for the secondary umbrella #8341

merged 2 commits into from
Sep 22, 2023

Conversation

HoloRin
Copy link
Contributor

@HoloRin HoloRin commented May 25, 2023 •
edited
Loading

Set the secondary umbrella for mixed version testing to the latest v3.12.x

@mergify mergify bot added the bazel label May 25, 2023
@HoloRin HoloRin force-pushed the rin/use-3.12.0-rc.3-for-mixed-versions branch 4 times, most recently from 2ac8777 to 0fc58b3 Compare June 2, 2023 08:07
@HoloRin HoloRin changed the title Use the latest 3.12 rc for the secondary umbrella Use 3.12.0 for the secondary umbrella Jun 13, 2023
@HoloRin HoloRin force-pushed the rin/use-3.12.0-rc.3-for-mixed-versions branch from 0fc58b3 to b628317 Compare June 13, 2023 08:32
@ansd ansd mentioned this pull request Jun 15, 2023
Closed
@HoloRin HoloRin force-pushed the rin/use-3.12.0-rc.3-for-mixed-versions branch from b628317 to 19e121a Compare July 10, 2023 08:59
@HoloRin HoloRin changed the title Use 3.12.0 for the secondary umbrella Use 3.12.1 for the secondary umbrella Jul 10, 2023
@HoloRin HoloRin added this to the 3.13.0 milestone Jul 17, 2023
@HoloRin HoloRin force-pushed the rin/use-3.12.0-rc.3-for-mixed-versions branch from 19e121a to a8b2c60 Compare August 21, 2023 08:36
@HoloRin HoloRin changed the title Use 3.12.1 for the secondary umbrella Use 3.12.3 for the secondary umbrella Aug 21, 2023
@michaelklishin
Copy link
Collaborator

@pjk25 I assume we should update this PR and merge it, or close it for good?

@dumbbell
Copy link
Collaborator

dumbbell commented Sep 21, 2023 •
edited
Loading

The Khepri branch will need something like this because it needs the bug fix in #9005. It was merged in 3.11.21 and 3.12.3.

Currently, CI fails early with the following error:

ERROR: Error computing the main repository mapping: module not found in registries: [email protected]

The previous run had another failure in dynamic_ha_SUITE but I couldn't download the test logs archive. Perhaps there is some expiration set on Buildbuddy.

@HoloRin HoloRin force-pushed the rin/use-3.12.0-rc.3-for-mixed-versions branch from a8b2c60 to c6672b9 Compare September 21, 2023 07:35
@HoloRin
Copy link
Contributor Author

HoloRin commented Sep 21, 2023

It fails because the hypothetical merge commit is what is sent to CI. By updating the branch, it should pick up the newer osiris that is on main. I have updated it.

@HoloRin
Copy link
Contributor Author

HoloRin commented Sep 21, 2023

It seems there may be few legitimate failures in //deps/rabbit:dynamic_ha_SUITE-mixed? Are these fixed in the khepri branch?

https://app.buildbuddy.io/invocation/df8fcecd-a1a1-4f9a-8cc5-35ea5fafe97f?target=%2F%2Fdeps%2Frabbit%3Adynamic_ha_SUITE-mixed&targetStatus=6

@dumbbell
Copy link
Collaborator

There is a failure in that same testsuite in the Khepri branch because 3.11.18 doesn't have the maintenance mode Mnesia table replicated. I will look into this one, but it's probably another issue.

@HoloRin HoloRin changed the title Use 3.12.3 for the secondary umbrella Use 3.12.6 for the secondary umbrella Sep 22, 2023
@HoloRin HoloRin merged commit a482edc into main Sep 22, 2023
@HoloRin HoloRin deleted the rin/use-3.12.0-rc.3-for-mixed-versions branch September 22, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bazel
Projects
None yet
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@HoloRin @michaelklishin @dumbbell