Follow-up to #385

lukebakken · lukebakken · commit c006ff400fa5 · 2024-06-10T05:50:06.000-07:00
There is still a slim chance that the code in #385 will throw `InvalidOperationException`, since the check and call to `SetException` is not atomic. `ManualResetValueTaskSource` does not have `TrySetException` like `TaskCompletionSource`.
diff --git a/RabbitMQ.Stream.Client/Client.cs b/RabbitMQ.Stream.Client/Client.cs
@@ -976,11 +976,13 @@ public bool RunContinuationsAsynchronously
         public void SetException(Exception error)
         {
             // https://github.com/rabbitmq/rabbitmq-stream-dotnet-client/issues/384
-            // we need to check if the task is pending before setting the exception
-            if (_logic.GetStatus(_logic.Version) == ValueTaskSourceStatus.Pending)
+            try
             {
                 _logic.SetException(error);
             }
+            catch (InvalidOperationException)
+            {
+            }
         }
 
         void IValueTaskSource.GetResult(short token) => _logic.GetResult(token);

Original file line number	Diff line number	Diff line change
`@@ -976,11 +976,13 @@ public bool RunContinuationsAsynchronously`
`976`	`976`	`public void SetException(Exception error)`
`977`	`977`	`{`
`978`	`978`	`// https://github.com/rabbitmq/rabbitmq-stream-dotnet-client/issues/384`
`979`		`- // we need to check if the task is pending before setting the exception`
`980`		`- if (_logic.GetStatus(_logic.Version) == ValueTaskSourceStatus.Pending)`
	`979`	`+ try`
`981`	`980`	`{`
`982`	`981`	`_logic.SetException(error);`
`983`	`982`	`}`
	`983`	`+ catch (InvalidOperationException)`
	`984`	`+ {`
	`985`	`+ }`
`984`	`986`	`}`
`985`	`987`
`986`	`988`	`void IValueTaskSource.GetResult(short token) => _logic.GetResult(token);`