Skip to content

Commit 8e3866c

Browse files
committed
Fix tests after observability integration
1 parent 06c6a93 commit 8e3866c

File tree

4 files changed

+13
-36
lines changed

4 files changed

+13
-36
lines changed

src/main/java/com/rabbitmq/stream/codec/QpidProtonCodec.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
import org.apache.qpid.proton.codec.WritableBuffer;
3333

3434
public class QpidProtonCodec implements Codec {
35-
private static final MessageBuilderListener NO_OP_MESSAGE_BUILDER_LISTENER = (s, mb) -> null;
35+
static final MessageBuilderListener NO_OP_MESSAGE_BUILDER_LISTENER = (s, mb) -> null;
3636
private static final Function<String, String> MESSAGE_ANNOTATIONS_STRING_KEY_EXTRACTOR = k -> k;
3737
private static final Function<Symbol, String> MESSAGE_ANNOTATIONS_SYMBOL_KEY_EXTRACTOR =
3838
Symbol::toString;

src/main/java/com/rabbitmq/stream/codec/SimpleCodec.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,12 @@ public MessageBuilder messageBuilder() {
3939

4040
@Override
4141
public MessageBuilder messageBuilder(String stream) {
42-
return null;
42+
return new SimpleMessageBuilder();
4343
}
4444

4545
@Override
4646
public Codec messageBuilderListener(MessageBuilderListener listener) {
47-
return null;
47+
return new SimpleCodec();
4848
}
4949

5050
@Override

src/test/java/com/rabbitmq/stream/codec/CodecsTest.java

Lines changed: 7 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
1414
package com.rabbitmq.stream.codec;
1515

16+
import static java.util.Arrays.asList;
1617
import static org.assertj.core.api.Assertions.assertThat;
1718
import static org.assertj.core.api.Assertions.assertThatThrownBy;
1819
import static org.mockito.Mockito.mock;
@@ -32,7 +33,6 @@
3233
import java.nio.charset.Charset;
3334
import java.nio.charset.StandardCharsets;
3435
import java.util.ArrayList;
35-
import java.util.Arrays;
3636
import java.util.Date;
3737
import java.util.List;
3838
import java.util.UUID;
@@ -53,7 +53,7 @@ public class CodecsTest {
5353
static UUID TEST_UUID = UUID.randomUUID();
5454

5555
static Iterable<CodecCouple> codecsCouples() {
56-
List<Codec> codecs = Arrays.asList(new QpidProtonCodec(), new SwiftMqCodec());
56+
List<Codec> codecs = asList(new QpidProtonCodec(), new SwiftMqCodec());
5757
List<CodecCouple> couples = new ArrayList<>();
5858
for (Codec serializer : codecs) {
5959
for (Codec deserializer : codecs) {
@@ -65,14 +65,14 @@ static Iterable<CodecCouple> codecsCouples() {
6565
}
6666

6767
static Iterable<Supplier<MessageBuilder>> messageBuilderSuppliers() {
68-
return Arrays.asList(
69-
new MessageBuilderCreator(QpidProtonMessageBuilder.class),
70-
new MessageBuilderCreator(SwiftMqMessageBuilder.class),
71-
new MessageBuilderCreator(WrapperMessageBuilder.class));
68+
return asList(
69+
() -> new QpidProtonMessageBuilder("", (stream, builder) -> null),
70+
SwiftMqMessageBuilder::new,
71+
WrapperMessageBuilder::new);
7272
}
7373

7474
static Iterable<Codec> readCreatedMessage() {
75-
return Arrays.asList(
75+
return asList(
7676
when(mock(Codec.class).messageBuilder()).thenReturn(new WrapperMessageBuilder()).getMock(),
7777
new QpidProtonCodec(),
7878
new SwiftMqCodec());
@@ -598,29 +598,4 @@ public String toString() {
598598
+ messageBuilderSupplier.get().getClass().getSimpleName();
599599
}
600600
}
601-
602-
static class MessageBuilderCreator implements Supplier<MessageBuilder> {
603-
604-
final Supplier<MessageBuilder> supplier;
605-
606-
MessageBuilderCreator(Class<? extends MessageBuilder> clazz) {
607-
supplier =
608-
() -> {
609-
try {
610-
return clazz.getDeclaredConstructor().newInstance();
611-
} catch (Exception e) {
612-
throw new RuntimeException(e);
613-
}
614-
};
615-
}
616-
617-
public MessageBuilder get() {
618-
return supplier.get();
619-
}
620-
621-
@Override
622-
public String toString() {
623-
return get().getClass().getSimpleName();
624-
}
625-
}
626601
}

src/test/java/com/rabbitmq/stream/impl/StreamProducerUnitTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright (c) 2021-2022 VMware, Inc. or its affiliates. All rights reserved.
1+
// Copyright (c) 2021-2023 VMware, Inc. or its affiliates. All rights reserved.
22
//
33
// This software, the RabbitMQ Stream Java client library, is dual-licensed under the
44
// Mozilla Public License 2.0 ("MPL"), and the Apache License version 2 ("ASL").
@@ -22,6 +22,7 @@
2222

2323
import com.rabbitmq.stream.ConfirmationHandler;
2424
import com.rabbitmq.stream.Constants;
25+
import com.rabbitmq.stream.ObservationCollector;
2526
import com.rabbitmq.stream.StreamException;
2627
import com.rabbitmq.stream.codec.SimpleCodec;
2728
import com.rabbitmq.stream.compression.Compression;
@@ -112,6 +113,7 @@ void init() {
112113
when(env.locatorOperation(any())).thenCallRealMethod();
113114
when(env.clock()).thenReturn(clock);
114115
when(env.codec()).thenReturn(new SimpleCodec());
116+
when(env.observationCollector()).thenReturn(ObservationCollector.NO_OP);
115117
doAnswer(
116118
(Answer<Runnable>)
117119
invocationOnMock -> {

0 commit comments

Comments
 (0)