Skip to content

Commit 71eacfa

Browse files
committed
Merge branch 'main' into update-all-composite-key
2 parents a232dd5 + 20d1c84 commit 71eacfa

File tree

8 files changed

+18
-15
lines changed

8 files changed

+18
-15
lines changed

.devcontainer/Dockerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ FROM mcr.microsoft.com/devcontainers/ruby:${VARIANT}
66

77
# TinyTDS
88
RUN apt-get -y install libc6-dev \
9-
&& wget http://www.freetds.org/files/stable/freetds-1.1.32.tar.gz \
10-
&& tar -xzf freetds-1.1.32.tar.gz \
11-
&& cd freetds-1.1.32 \
9+
&& wget http://www.freetds.org/files/stable/freetds-1.4.14.tar.gz \
10+
&& tar -xzf freetds-1.4.14.tar.gz \
11+
&& cd freetds-1.4.14 \
1212
&& ./configure --prefix=/usr/local --with-tdsver=7.3 \
1313
&& make \
1414
&& make install

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ jobs:
1414
fail-fast: false
1515
matrix:
1616
ruby:
17-
- 3.1.4
18-
- 3.2.2
19-
- 3.3.0
17+
- 3.1.6
18+
- 3.2.4
19+
- 3.3.2
2020

2121
steps:
2222
- name: Checkout code

Dockerfile.ci

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@ WORKDIR $WORKDIR
99

1010
COPY . $WORKDIR
1111

12-
RUN RAILS_BRANCH=7-2-stable bundle install --jobs `expr $(cat /proc/cpuinfo | grep -c "cpu cores") - 1` --retry 3
12+
RUN bundle install --jobs `expr $(cat /proc/cpuinfo | grep -c "cpu cores") - 1` --retry 3
1313

1414
CMD ["sh"]

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ gemspec
88

99
gem "bcrypt"
1010
gem "pg", ">= 0.18.0"
11-
gem "sqlite3", "~> 1.4"
11+
gem "sqlite3", ">= 1.6.6"
1212
gem "tzinfo-data", platforms: [:mingw, :mswin, :x64_mingw, :jruby]
1313
gem "benchmark-ips"
1414
gem "minitest", ">= 5.15.0"

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
7.2.0.alpha
1+
7.2.0.beta2

activerecord-sqlserver-adapter.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,6 @@ Gem::Specification.new do |spec|
2727
spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
2828
spec.require_paths = ["lib"]
2929

30-
spec.add_dependency "activerecord", "~> 7.2.0.alpha"
30+
spec.add_dependency "activerecord", "~> 7.2.0.beta2"
3131
spec.add_dependency "tiny_tds"
3232
end

docker-compose.ci.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ services:
55
ci:
66
environment:
77
- ACTIVERECORD_UNITTEST_HOST=sqlserver
8-
- RAILS_BRANCH=7-2-stable
98
build:
109
context: .
1110
dockerfile: Dockerfile.ci

test/cases/rake_test_sqlserver.rb

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -138,18 +138,22 @@ class SQLServerRakeStructureDumpLoadTest < SQLServerRakeTest
138138

139139
it "dumps structure and accounts for defncopy oddities" do
140140
skip "debug defncopy on windows later" if host_windows?
141+
141142
quietly { db_tasks.structure_dump configuration, filename }
143+
142144
_(filedata).wont_match %r{\AUSE.*\z}
143145
_(filedata).wont_match %r{\AGO.*\z}
144-
_(filedata).must_match %r{email\s+nvarchar\(4000\)}
145-
_(filedata).must_match %r{background1\s+nvarchar\(max\)}
146-
_(filedata).must_match %r{background2\s+text\s+}
146+
_(filedata).must_match %r{\[email\]\s+nvarchar\(4000\)}
147+
_(filedata).must_match %r{\[background1\]\s+nvarchar\(max\)}
148+
_(filedata).must_match %r{\[background2\]\s+text\s+}
147149
end
148150

149151
it "can load dumped structure" do
150152
skip "debug defncopy on windows later" if host_windows?
153+
151154
quietly { db_tasks.structure_dump configuration, filename }
152-
_(filedata).must_match %r{CREATE TABLE dbo\.users}
155+
156+
_(filedata).must_match %r{CREATE TABLE \[dbo\]\.\[users\]}
153157
db_tasks.purge(configuration)
154158
_(connection.tables).wont_include "users"
155159
db_tasks.load_schema db_config, :sql, filename

0 commit comments

Comments
 (0)