Skip to content

Add assertions to tests missing any assertions #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2024
Merged

Add assertions to tests missing any assertions #1193

merged 2 commits into from
Jun 9, 2024

Conversation

aidanharan
Copy link
Contributor

Fix missing assertions warnings like:

https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/9430052163/job/25977137751?pr=1189

Test is missing assertions: `test_0001_records can be created successfully` /activerecord-sqlserver-adapter/test/cases/adapter_test_sqlserver.rb:551

@aidanharan aidanharan marked this pull request as ready for review June 9, 2024 16:12
@aidanharan aidanharan merged commit 34e5852 into main Jun 9, 2024
8 checks passed
@aidanharan aidanharan deleted the add-missing-assertions branch June 9, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rails-7.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aidanharan