Skip to content

Fix missing assertion warning #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2024
Merged

Fix missing assertion warning #1195

merged 1 commit into from
Jun 13, 2024

Conversation

aidanharan
Copy link
Contributor

Fix missing assertions message. Issue caused by return in block returning from the calling test.

https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/9437921639/job/25994350714

Test is missing assertions: `test_0006_test deprecation with transaction return when executing procedure` /activerecord-sqlserver-adapter/test/cases/execute_procedure_test_sqlserver.rb:45

@aidanharan aidanharan marked this pull request as ready for review June 13, 2024 18:15
@aidanharan aidanharan merged commit b0d3726 into main Jun 13, 2024
5 checks passed
@aidanharan aidanharan deleted the missing-assertion-warning branch June 13, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rails-7.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aidanharan