Skip to content

Fix for checking if raw connection transaction open #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

aidanharan
Copy link
Contributor

Fix for checking if raw connection transaction open.

https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/13243848935/job/36965406558

  2) Failure:
ActiveRecord::AdapterConnectionTest#test_0006_unmaterialized transaction state can be restored after a reconnect [/usr/local/bundle/bundler/gems/rails-50efa73e0a96/activerecord/test/cases/adapter_test.rb:604]:
Expected false to be truthy.

  3) Failure:
ActiveRecord::AdapterConnectionTest#test_0003_materialized transaction state can be restored after a reconnect [/usr/local/bundle/bundler/gems/rails-50efa73e0a96/activerecord/test/cases/adapter_test.rb:570]:
Expected false to be truthy.

  4) Failure:
ActiveRecord::AdapterConnectionTest#test_0002_materialized transaction state is reset after a reconnect [/usr/local/bundle/bundler/gems/rails-50efa73e0a96/activerecord/test/cases/adapter_test.rb:560]:
Expected false to be truthy.

  5) Failure:
ActiveRecord::AdapterConnectionTest#test_0004_materialized transaction state is reset after a disconnect [/usr/local/bundle/bundler/gems/rails-50efa73e0a96/activerecord/test/cases/adapter_test.rb:580]:
Expected false to be truthy.

@aidanharan aidanharan marked this pull request as ready for review February 11, 2025 11:06
@aidanharan aidanharan merged commit c45f7c4 into main Feb 11, 2025
2 of 5 checks passed
@aidanharan aidanharan deleted the raw-transaction-open branch February 11, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant