Skip to content

Commit 493cd94

Browse files
authored
Remove needless webpack-cli installing (#96)
The `webpack-cli` was already installed by `javascript:install:webpack` that run at `Setup jsbundling-rails` section before. https://github.com/rails/jsbundling-rails/blob/f71e7564f6717a0cdacaa93c673360254d77b8e0/lib/install/webpack/install.rb#L3 So you don't need to install at this point.
1 parent f71e756 commit 493cd94

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

docs/switch_from_webpacker.md

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ If you would like to minimize the diff between Webpacker and jsbundling-rails:
5353

5454
## 2. Remove Webpacker
5555

56-
1. Delete the following files, ensuring that you've migrated any customizations you've done in them:
56+
1. Delete the following files, ensuring that you've migrated any customizations you've done in them:
5757

5858
- `./bin/webpack`
5959
- `./bin/webpack-dev-server`
@@ -75,13 +75,10 @@ If you would like to minimize the diff between Webpacker and jsbundling-rails:
7575

7676
## 3. Install dependencies
7777

78-
Webpacker includes [many dependencies](https://github.com/rails/webpacker/blob/5-x-stable/package.json) by default while jsbundling-rails leaves it to you. If you're only handling JavaScript with no modifications you'll only need to install `webpack-cli`. Treat the rest of this section ala-carte.
78+
Webpacker includes [many dependencies](https://github.com/rails/webpacker/blob/5-x-stable/package.json) by default while jsbundling-rails leaves it to you. If you're only handling JavaScript with no modifications you don't need to install additional packages. Treat the rest of this section ala-carte.
7979

8080
```sh
81-
# From the CLI, add webpack-cli
82-
yarn add webpack-cli
83-
84-
# Then remove Webpacker packages
81+
# From the CLI, remove Webpacker packages
8582
yarn remove @rails/webpacker webpack-dev-server
8683
```
8784

0 commit comments

Comments
 (0)