Stop catching Nokogiri::CSS::SyntaxError

Author: davidcornu

lib/rails/dom/testing/assertions/selector_assertions.rb

@@ -62,9 +62,6 @@ def css_select(*args)
           root = args.size == 1 ? document_root_element : args.shift
 
           nodeset(root).css(args.first)
-        rescue Nokogiri::CSS::SyntaxError => e
-          ActiveSupport::Deprecation.warn("The assertion was not run because of an invalid css selector.\n#{e}", caller(2))
-          return
         end
 
         # An assertion that selects elements and makes one or more equality tests.
@@ -177,9 +174,6 @@ def assert_select(*args, &block)
 
             nest_selection(matches, &block) if block_given? && !matches.empty?
           end
-        rescue Nokogiri::CSS::SyntaxError => e
-          ActiveSupport::Deprecation.warn("The assertion was not run because of an invalid css selector.\n#{e}", caller(2))
-          return
         end
 
         # Extracts the content of an element, treats it as encoded HTML and runs

test/selector_assertions_test.rb

@@ -220,15 +220,15 @@ def test_nested_css_select
   # testing invalid selectors
   def test_assert_select_with_invalid_selector
     render_html '<a href="http://example.com">hello</a>'
-    assert_deprecated do
-      assert_nil assert_select("[href=http://example.com]")
+    assert_raises Nokogiri::CSS::SyntaxError do
+      assert_select("[href=http://example.com]")
     end
   end
 
   def test_css_select_with_invalid_selector
     render_html '<a href="http://example.com">hello</a>'
-    assert_deprecated do
-      assert_nil css_select("[href=http://example.com]")
+    assert_raises Nokogiri::CSS::SyntaxError do
+      css_select("[href=http://example.com]")
     end
   end