Skip to content

Commit 3a86599

Browse files
authored
Merge pull request #34620 from ysksn/use_safe_navigation_operator_for_railsguides_generator_constructor
Use String for direction of RailsGuides::Generator#new
2 parents 7849e56 + cb343ef commit 3a86599

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

guides/rails_guides.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,5 @@
2626
only: env_value["ONLY"],
2727
kindle: env_flag["KINDLE"],
2828
language: env_value["GUIDES_LANGUAGE"],
29-
direction: env_value["DIRECTION"].to_sym
29+
direction: env_value["DIRECTION"]
3030
).generate

guides/rails_guides/generator.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ module RailsGuides
1717
class Generator
1818
GUIDES_RE = /\.(?:erb|md)\z/
1919

20-
def initialize(edge:, version:, all:, only:, kindle:, language:, direction: :ltr)
20+
def initialize(edge:, version:, all:, only:, kindle:, language:, direction: "ltr")
2121
@edge = edge
2222
@version = version
2323
@all = all
@@ -118,7 +118,7 @@ def select_only(guides)
118118
def copy_assets
119119
FileUtils.cp_r(Dir.glob("#{@guides_dir}/assets/*"), @output_dir)
120120

121-
if @direction == :rtl
121+
if @direction == "rtl"
122122
overwrite_css_with_right_to_left_direction
123123
end
124124
end

0 commit comments

Comments
 (0)