Skip to content

Commit 98bb6cd

Browse files
committed
Make build work again.
1 parent 7e87eca commit 98bb6cd

File tree

3 files changed

+42
-3
lines changed

3 files changed

+42
-3
lines changed

byte-buddy-gradle-plugin/android-plugin/src/main/java/net/bytebuddy/build/gradle/android/ByteBuddyAndroidTaskExtension.java

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,10 @@
1717

1818
import groovy.lang.Closure;
1919
import net.bytebuddy.build.EntryPoint;
20+
import net.bytebuddy.utility.nullability.MaybeNull;
2021
import org.gradle.api.Action;
2122
import org.gradle.api.Project;
23+
import org.gradle.api.file.FileCollection;
2224

2325
import java.util.ArrayList;
2426
import java.util.List;
@@ -81,6 +83,12 @@ public class ByteBuddyAndroidTaskExtension {
8183
*/
8284
private int threads;
8385

86+
/**
87+
* A set of classes that is used for discovery of plugins.
88+
*/
89+
@MaybeNull
90+
private FileCollection discoverySet;
91+
8492
/**
8593
* Creates a new abstract Byte Buddy task extension.
8694
*
@@ -270,6 +278,25 @@ public void setThreads(int threads) {
270278
this.threads = threads;
271279
}
272280

281+
/**
282+
* Returns the source set to resolve plugin names from or {@code null} if no such source set is used.
283+
*
284+
* @return The source set to resolve plugin names from or {@code null} if no such source set is used.
285+
*/
286+
@MaybeNull
287+
public FileCollection getDiscoverySet() {
288+
return discoverySet;
289+
}
290+
291+
/**
292+
* Defines the source set to resolve plugin names from or {@code null} if no such source set is used.
293+
*
294+
* @param discoverySet The source set to resolve plugin names from or {@code null} if no such source set is used.
295+
*/
296+
public void setDiscoverySet(@MaybeNull FileCollection discoverySet) {
297+
this.discoverySet = discoverySet;
298+
}
299+
273300
/**
274301
* Applies this extension's properties.
275302
*
@@ -285,5 +312,6 @@ protected void configure(ByteBuddyLocalClassesEnhancerTask task) {
285312
task.getExtendedParsing().convention(isExtendedParsing());
286313
task.getDiscovery().convention(getDiscovery());
287314
task.getThreads().convention(getThreads());
315+
task.getDiscoverySet().setFrom(getDiscoverySet());
288316
}
289317
}

byte-buddy-gradle-plugin/android-plugin/src/main/java/net/bytebuddy/build/gradle/android/ByteBuddyLocalClassesEnhancerTask.java

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
import org.gradle.api.provider.ListProperty;
3535
import org.gradle.api.provider.Property;
3636
import org.gradle.api.tasks.*;
37+
import org.gradle.api.tasks.Optional;
3738

3839
import java.io.*;
3940
import java.lang.reflect.InvocationTargetException;
@@ -167,6 +168,16 @@ public abstract class ByteBuddyLocalClassesEnhancerTask extends DefaultTask {
167168
@Input
168169
public abstract Property<Boolean> getExtendedParsing();
169170

171+
/**
172+
* Returns the source set to resolve plugin names from or {@code null} if no such source set is used.
173+
*
174+
* @return The source set to resolve plugin names from or {@code null} if no such source set is used.
175+
*/
176+
@MaybeNull
177+
@InputFiles
178+
@Optional
179+
public abstract ConfigurableFileCollection getDiscoverySet();
180+
170181
/**
171182
* Translates a collection of files to {@link URL}s.
172183
*
@@ -239,7 +250,7 @@ public void execute() throws IOException {
239250
discovery.getMethod("valueOf", String.class).invoke(null, getDiscovery().get().name()),
240251
ClassFileLocator.ForClassLoader.of(ByteBuddy.class.getClassLoader()),
241252
getAndroidBootClasspath().plus(getByteBuddyClasspath()).getFiles(),
242-
Collections.emptyList(), // TODO
253+
getDiscoverySet().getFiles(),
243254
getEntryPoint().get(),
244255
classFileVersion,
245256
Plugin.Factory.UsingReflection.ArgumentResolver.ForType.of(AndroidDescriptor.class, androidDescriptor),

byte-buddy-gradle-plugin/src/main/java/net/bytebuddy/build/gradle/AbstractByteBuddyTask.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,7 @@ public static void apply(Logger logger,
417417
Discovery discovery,
418418
ClassFileLocator rootLocator,
419419
Iterable<File> artifacts,
420-
Iterable<File> discoveries,
420+
@MaybeNull Iterable<File> discoveries,
421421
EntryPoint entryPoint,
422422
ClassFileVersion classFileVersion,
423423
Plugin.Factory.UsingReflection.ArgumentResolver rootLocationResolver,
@@ -429,8 +429,8 @@ public static void apply(Logger logger,
429429
boolean warnOnEmptyTypeSet,
430430
Plugin.Engine.Source source,
431431
Plugin.Engine.Target target) throws IOException {
432-
ClassLoader classLoader = ByteBuddySkippingUrlClassLoader.of(rootLoader, discoveries);
433432
Plugin.Engine.Summary summary;
433+
ClassLoader classLoader = ByteBuddySkippingUrlClassLoader.of(rootLoader, discoveries);
434434
try {
435435
if (discovery.isDiscover(transformations)) {
436436
Set<String> undiscoverable = new HashSet<String>();

0 commit comments

Comments
 (0)