fix: children component update

silentcloud · silentcloud · commit d59b28dbf0f5 · 2017-09-06T19:03:11.000+08:00
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "rmc-dialog",
-  "version": "0.0.1-alpha.2",
+  "version": "0.0.1-alpha.3",
   "description": "mobile dialog ui component for react",
   "keywords": [
     "react",
diff --git a/src/DialogWrap.tsx b/src/DialogWrap.tsx
@@ -23,10 +23,6 @@ export default class DialogWrap extends React.Component<IDialogPropTypes, any> {
     this.renderDialog(false);
   }
 
-  shouldComponentUpdate(nextProps) {
-    return nextProps.visible !== this.props.visible;
-  }
-
   componentDidUpdate() {
     this.renderDialog(this.props.visible);
   }

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "rmc-dialog",`
`3`		`- "version": "0.0.1-alpha.2",`
	`3`	`+ "version": "0.0.1-alpha.3",`
`4`	`4`	`"description": "mobile dialog ui component for react",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"react",`
Original file line number	Diff line number	Diff line change
`@@ -23,10 +23,6 @@ export default class DialogWrap extends React.Component<IDialogPropTypes, any> {`
`23`	`23`	`this.renderDialog(false);`
`24`	`24`	`}`
`25`	`25`
`26`		`- shouldComponentUpdate(nextProps) {`
`27`		`- return nextProps.visible !== this.props.visible;`
`28`		`- }`
`29`		`-`
`30`	`26`	`componentDidUpdate() {`
`31`	`27`	`this.renderDialog(this.props.visible);`
`32`	`28`	`}`