type: onChange callback should define 'option' as Option | Option[] | undefined (#1090)

thinkasany · web-flow · commit 35546c0e9a9f · 2024-11-27T15:07:43.000+08:00
diff --git a/src/Select.tsx b/src/Select.tsx
@@ -161,7 +161,7 @@ export interface SelectProps<ValueType = any, OptionType extends BaseOptionType
   value?: ValueType | null;
   defaultValue?: ValueType | null;
   maxCount?: number;
-  onChange?: (value: ValueType, option: OptionType | OptionType[]) => void;
+  onChange?: (value: ValueType, option?: OptionType | OptionType[]) => void;
 }
 
 function isRawValue(value: DraftValueType): value is RawValueType {

Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,7 @@ export interface SelectProps<ValueType = any, OptionType extends BaseOptionType`
`161`	`161`	`value?: ValueType \| null;`
`162`	`162`	`defaultValue?: ValueType \| null;`
`163`	`163`	`maxCount?: number;`
`164`		`- onChange?: (value: ValueType, option: OptionType \| OptionType[]) => void;`
	`164`	`+ onChange?: (value: ValueType, option?: OptionType \| OptionType[]) => void;`
`165`	`165`	`}`
`166`	`166`
`167`	`167`	`function isRawValue(value: DraftValueType): value is RawValueType {`