Skip to content

Commit 1fe0e19

Browse files
authored
Merge pull request #29 from react-native-community/fixes-and-cleaning
Fixes and cleaning
2 parents 3261b2c + 22f3ed6 commit 1fe0e19

File tree

9 files changed

+1762
-150
lines changed

9 files changed

+1762
-150
lines changed

.gitignore

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,14 @@
1-
.idea/*
1+
# VSCode
2+
.vscode/
3+
jsconfig.json
24

5+
# IntelliJ/Webstorm
6+
.idea
7+
8+
# OS X
9+
.DS_Store
10+
11+
# NodeJS
12+
npm-debug.log
313
node_modules
14+
yarn-error.log

.release-it.json

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
{
2+
"npm": {
3+
"publish": true
4+
},
5+
"github": {
6+
"release": true
7+
}
8+
}

README.md

Lines changed: 2 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ yarn add react-native-hooks
2424
- [useCameraRoll](https://github.com/react-native-community/react-native-hooks#usecameraroll)
2525
- [useClipboard](https://github.com/react-native-community/react-native-hooks#useclipboard)
2626
- [useDimensions](https://github.com/react-native-community/react-native-hooks#usedimensions)
27-
- [useGeolocation](https://github.com/react-native-community/react-native-hooks#usegeolocation)
28-
- [useNetInfo](https://github.com/react-native-community/react-native-hooks#usenetinfo)
2927
- [useKeyboard](https://github.com/react-native-community/react-native-hooks#usekeyboard)
3028
- [useInteractionManager](https://github.com/react-native-community/react-native-hooks#useinteractionmanager)
3129
- [useDeviceOrientation](https://github.com/react-native-community/react-native-hooks#usedeviceorientation)
@@ -81,35 +79,15 @@ import { useDimensions } from 'react-native-hooks'
8179
const dimensions = useDimensions()
8280
```
8381

84-
### `useGeolocation`
85-
86-
```js
87-
import { useGeolocation } from 'react-native-hooks'
88-
89-
const [position, stopObserving, setRNConfiguration] = useGeolocation()
90-
91-
console.log('latitude: ', position.coords.latitude)
92-
```
93-
94-
### `useNetInfo`
95-
96-
```js
97-
import { useNetInfo } from 'react-native-hooks'
98-
99-
const netInfo = useNetInfo()
100-
101-
console.log('netInfo type: ', netInfo.type)
102-
```
103-
10482
### `useKeyboard`
10583

10684
```js
10785
import { useKeyboard } from 'react-native-hooks'
10886

10987
const keyboard = useKeyboard()
11088

111-
console.log('keyboard show: ', keyboard.show)
112-
console.log('keyboard height: ', keyboard.height)
89+
console.log('keyboard show: ', keyboard.isKeyboardShow)
90+
console.log('keyboard height: ', keyboard.keyboardHeight)
11391
```
11492

11593
### `useInteractionManager`

index.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@ import useAppState from './lib/useAppState'
33
import useCameraRoll from './lib/useCameraRoll'
44
import useClipboard from './lib/useClipboard'
55
import useAccessibilityInfo from './lib/useAccessibilityInfo'
6-
import useGeolocation from './lib/useGeolocation'
7-
import useNetInfo from './lib/useNetInfo'
86
import useKeyboard from './lib/useKeyboard'
97
import useInteractionManager from './lib/useInteractionManager'
108
import useDeviceOrientation from './lib/useDeviceOrientation'
@@ -15,8 +13,6 @@ export {
1513
useCameraRoll,
1614
useClipboard,
1715
useAccessibilityInfo,
18-
useGeolocation,
19-
useNetInfo,
2016
useKeyboard,
2117
useInteractionManager,
2218
useDeviceOrientation,

lib/useGeolocation.js

Lines changed: 0 additions & 50 deletions
This file was deleted.

lib/useKeyboard.js

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,33 +4,33 @@ import { Keyboard } from 'react-native'
44
export default () => {
55
const [keyboard, setKeyboard] = useState({})
66

7-
keyboardWillShow = e => {
7+
function keyboardDidShow(e) {
88
setKeyboard({
99
isKeyboardShow: true,
1010
keyboardHeight: e.endCoordinates.height
1111
})
1212
}
1313

14-
keyboardWillHide = e => {
14+
function keyboardDidHide(e) {
1515
setKeyboard({
1616
isKeyboardShow: false,
1717
keyboardHeight: e.endCoordinates.height
1818
})
1919
}
2020

2121
useEffect(() => {
22-
this.keyboardWillShowListener = Keyboard.addListener(
23-
'keyboardWillShow',
24-
keyboardWillShow
22+
this.keyboardDidShowListener = Keyboard.addListener(
23+
'keyboardDidShow',
24+
keyboardDidShow
2525
)
26-
this.keyboardWillHideListener = Keyboard.addListener(
27-
'keyboardWillHide',
28-
keyboardWillHide
26+
this.keyboardDidHideListener = Keyboard.addListener(
27+
'keyboardDidHide',
28+
keyboardDidHide
2929
)
3030

3131
return () => {
32-
this.keyboardWillShowListener.remove()
33-
this.keyboardWillHideListener.remove()
32+
this.keyboardDidShowListener.remove()
33+
this.keyboardDidHideListener.remove()
3434
}
3535
}, [])
3636
return keyboard

lib/useNetInfo.js

Lines changed: 0 additions & 30 deletions
This file was deleted.

package.json

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,19 @@
11
{
22
"name": "react-native-hooks",
3-
"version": "0.0.7",
3+
"version": "0.0.8",
44
"description": "",
55
"main": "index.js",
66
"scripts": {
7-
"test": "echo \"Error: no test specified\" && exit 1"
7+
"test": "echo \"Error: no test specified\" && exit 1",
8+
"release": "release-it"
89
},
910
"author": "Nader Dabit",
1011
"license": "ISC",
11-
"dependencies": {
12-
"react": "^16.8.3"
12+
"peerDependencies": {
13+
"react": ">=16.8.0",
14+
"react-native": ">=0.59"
15+
},
16+
"devDependencies": {
17+
"release-it": "^12.3.5"
1318
}
1419
}

0 commit comments

Comments
 (0)