Skip to content

fix onChange array functions #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix onChange array functions #33

wants to merge 2 commits into from

Conversation

Freddy03h
Copy link

Summary

Fix onChange in useDeviceOrientation and useDimensions array fonction.

Define the const to fix serious issues that can happen if you already had a function called onChange inside the component that use those hooks.

@pvinis
Copy link
Member

pvinis commented Nov 1, 2019

Thank you for this. I think we have this addressed in #41.

@Freddy03h
Copy link
Author

Yes I think too

@pvinis pvinis closed this Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Freddy03h @pvinis