@vonovak/delete extra files #22
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naturalclar
reviewed
Feb 3, 2020
Naturalclar
requested changes
Feb 3, 2020
There was a problem hiding this comment.
@vonovak Thanks! I noticed the same problem and deleted some files that were colliding, but I had missed some files.
I'd like to keep all the files with ProgressView in the name (with capital V) and delete delete all Progressview instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
git clone told me:
warning: the following paths have collided (e.g. case-sensitive paths
on a case-insensitive filesystem) and only one from the same
colliding group is in the working tree:
'ios/RNCProgressView.h'
'ios/RNCProgressview.h'
'ios/RNCProgressView.m'
'ios/RNCProgressview.m'
'ios/RNCProgressView.xcodeproj/project.pbxproj'
'ios/RNCProgressview.xcodeproj/project.pbxproj'
the contents of those files were identical so I removed them
Test Plan
this should work locally but seems like the setup is different than in other repos so not quite sure to verify this. - maybe @Naturalclar will know better
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdCHANGELOG.mdexample/App.js)