Skip to content

BackendFixture fails with Sanic because missing test_mode #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rmorshea opened this issue Dec 29, 2022 Discussed in #860 · 1 comment
Closed

BackendFixture fails with Sanic because missing test_mode #861

rmorshea opened this issue Dec 29, 2022 Discussed in #860 · 1 comment
Labels
type-tests About the test suite
Milestone
1.0.0

Comments

@rmorshea
Copy link
Collaborator

Discussed in #860

Originally posted by ahopkins December 29, 2022
The problem was reported here: sanic-org/sanic#2643.

The issue is that the BackendFixture for testing Sanic does not set Sanic.test_mode = True, which means that there is potential for issues (as seen the linked issue) to arise. I propose that you add this into your test implementation for Sanic to automatically manage setting that variable.
@rmorshea rmorshea added type: bug type-tests About the test suite labels Dec 29, 2022
@Archmonger Archmonger added this to the 2.0 milestone Dec 30, 2022
@rmorshea
Copy link
Collaborator Author

rmorshea commented Jan 7, 2023

I think this was fixed by: #862

@rmorshea rmorshea closed this as completed Jan 7, 2023
@Archmonger Archmonger modified the milestones: Luxury, 1.0 Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-tests About the test suite
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@rmorshea @Archmonger