Skip to content

Commit bb2c334

Browse files
csvnbenlesh
authored andcommitted
perf: remove comments from js-files (#3760)
Strip comments from all .js files (except legacy-reexports and compat) while retaining them for .d.ts files. The legacy-reexport does not have any comments and will be removed with compat in next major version. ``` npx get-folder-size --folder=dist/package // 5.88 Mb (with comments) // 4.63 Mb (without comments) ``` Roughly 1.25 Mb is saved by removing comments.
1 parent a95441b commit bb2c334

File tree

6 files changed

+18
-4
lines changed

6 files changed

+18
-4
lines changed

package.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,15 @@
4141
"scripts": {
4242
"precommit": "lint-staged",
4343
"commitmsg": "validate-commit-msg",
44-
"build_all": "npm-run-all compat_build_all clean_dist copy_sources build_cjs build_esm5 build_esm2015 build_esm5_for_rollup build_umd build_legacy_reexport build_migrations generate_packages copy_for_tests",
44+
"build_all": "npm-run-all compat_build_all clean_dist copy_sources build_cjs build_esm5 build_esm2015 build_esm5_for_rollup build_umd build_types build_legacy_reexport build_migrations generate_packages copy_for_tests",
4545
"build_cjs": "npm-run-all clean_dist_cjs compile_dist_cjs",
4646
"build_esm5": "npm-run-all clean_dist_esm5 compile_dist_esm5",
4747
"build_esm5_for_rollup": "npm-run-all clean_dist_esm5_for_rollup compile_dist_esm5_for_rollup && mkdirp dist/esm5_for_rollup/node_modules && shx cp -r ./dist-compat/package ./dist/esm5_for_rollup/node_modules/rxjs-compat",
4848
"build_esm2015": "npm-run-all clean_dist_esm2015 compile_dist_esm2015",
4949
"build_esm2015_for_docs": "npm-run-all clean_dist_esm2015 compile_dist_esm2015_for_docs",
5050
"build_legacy_reexport": "npm-run-all compile_legacy_reexport",
5151
"build_migrations": "npm-run-all clean_dist_migrations compile_dist_migrations",
52+
"build_types": "npm-run-all clean_dist_types compile_dist_types",
5253
"build_closure_core": "node ./tools/make-closure-core.js",
5354
"build_global": "npm-run-all clean_dist_global build_esm5_for_rollup && mkdirp ./dist/global && node ./tools/make-umd-bundle.js && npm-run-all build_closure_core clean_dist_esm5_for_rollup",
5455
"build_umd": "npm-run-all clean_dist_global && mkdirp ./dist/global && node ./tools/make-umd-bundle.js && npm-run-all build_closure_core",
@@ -64,13 +65,15 @@
6465
"clean_dist_esm2015": "shx rm -rf ./dist/esm2015",
6566
"clean_dist_global": "shx rm -rf ./dist/global",
6667
"clean_dist_migrations": "shx rm -rf ./dist/migrations",
68+
"clean_dist_types": "shx rm -rf ./dist/typings",
6769
"commit": "git-cz",
6870
"compile_dist_cjs": "tsc -p ./tsconfig/tsconfig.cjs.json",
6971
"compile_dist_esm5": "tsc -p ./tsconfig/tsconfig.esm5.json",
7072
"compile_dist_esm2015": "tsc -p ./tsconfig/tsconfig.esm2015.json",
7173
"compile_dist_esm2015_for_docs": "tsc ./dist/src/internal/Rx.ts ./dist/src/add/observable/of.ts ./dist/src/MiscJSDoc.ts -m es2015 --sourceMap --outDir ./dist/es6 --target es2015 -d --diagnostics --pretty --noImplicitAny --noImplicitReturns --noImplicitThis --suppressImplicitAnyIndexErrors --moduleResolution node",
7274
"compile_dist_esm5_for_rollup": "tsc -p ./tsconfig/tsconfig.esm5.rollup.json",
7375
"compile_dist_migrations": "tsc -p ./tsconfig/tsconfig.migrations.json",
76+
"compile_dist_types": "tsc -p ./tsconfig/tsconfig.types.json",
7477
"compile_legacy_reexport": "tsc -p ./tsconfig/tsconfig.legacy-reexport.json",
7578
"copy_sources": "mkdirp dist && shx cp -r ./src/ ./dist/src",
7679
"copy_for_tests": "shx rm -rf ./spec-build && shx cp -r ./spec/ ./spec-build/ && mkdirp ./spec-build/node_modules && shx cp -r ./dist/package/ ./spec-build/node_modules/rxjs && shx cp -r ./dist-compat/package/ ./spec-build/node_modules/rxjs-compat",

tsconfig.base.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"compilerOptions": {
3-
"removeComments": false,
3+
"removeComments": true,
44
"preserveConstEnums": true,
55
"sourceMap": true,
66
"strictFunctionTypes": true,

tsconfig/compat/tsconfig.cjs.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
"compilerOptions": {
44
"module": "commonjs",
55
"target": "es5",
6+
"removeComments": false,
67
"declaration": true,
78
"declarationDir": "../../dist-compat/typings",
89
"outDir": "../../dist-compat/cjs"

tsconfig/tsconfig.cjs.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@
33
"compilerOptions": {
44
"module": "commonjs",
55
"target": "es5",
6-
"declaration": true,
7-
"declarationDir": "../dist/typings",
86
"outDir": "../dist/cjs"
97
}
108
}

tsconfig/tsconfig.legacy-reexport.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
"compilerOptions": {
44
"module": "commonjs",
55
"target": "es5",
6+
"removeComments": false,
67
"declaration": true,
78
"noEmit": false,
89
"outDir": "../dist/legacy-reexport",

tsconfig/tsconfig.types.json

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
{
2+
"extends": "./tsconfig.base.json",
3+
"compilerOptions": {
4+
"module": "es2015",
5+
"target": "esnext",
6+
"removeComments": false,
7+
"declaration": true,
8+
"declarationDir": "../dist/typings",
9+
"emitDeclarationOnly": true
10+
}
11+
}

0 commit comments

Comments
 (0)