Skip to content

Support source maps #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Daniel15 opened this issue Mar 24, 2014 · 4 comments
Closed

Support source maps #8

Daniel15 opened this issue Mar 24, 2014 · 4 comments
Assignees

Comments

@Daniel15
Copy link
Member

Files transformed to JSX on-the-fly should also output the associated source map

  • Does JSX transformation even support source maps at the moment?
  • May need to cache on disk in addition to in-memory? See if ASP.NET output caching with file dependency is sufficient.
@Daniel15 Daniel15 self-assigned this Mar 24, 2014
@jordwalke
Copy link
Member

Yes, the JSX transform supports sourcemaps. If you try https://github.com/facebook/react-page it will show them working.

@Daniel15
Copy link
Member Author

Basic support for when .jsx files are referenced directly was merged in 2894222. It's not supported for combined/minified files at the moment since none of the .NET minifiers support source maps. I've heard talk of the next version of Visual Studio supporting Gulp so perhaps we'll move in that direction (ReactJS.NET + Gulp rather than ReactJS.NET + [Cassette | ASP.NET Minification])

@zzz6519003
Copy link

does the react project itself support sourcemap? that way i can read source code more easily by debugging the program XD

@Daniel15
Copy link
Member Author

Yeah, source maps should be supported. ReactJS.NET supports source maps, as does React itself. Other third party libraries like Webpack, Gulp and Babel support source maps too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants