add context handlers #260
Merged
add context handlers #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two new handlers based on `handlers.propTypeHandler`.
danez
approved these changes
Apr 20, 2018
src/handlers/propTypeHandler.js
Outdated
| propTypesPath = resolveToValue(propTypesPath); | ||
| if (!propTypesPath) { | ||
| return; | ||
| export function getPropTypeHandler(propName: string) { |
There was a problem hiding this comment.
I guess this function must not necessarily be exported?
|
Would be great to see this get merged. |
glebez
force-pushed
the
child-context-types
branch
from
23980f7 to
8f825fd
Compare
|
Hey! The tiny little thing is fixed now. And thanks everyone for your patience. |
|
Thank you very much. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR builds up on the PR #130 that didn't show any activity for about a year now.
It introduces two new handlers for
contextTypeandchildContextTypebased on existingpropTypeHandler.I've rebased the stale branch, updated 2 fixtures and snapshots (as was requested in the above PR) and also fixed some linter errors. Let me know if any other changes are required, please.
Thanks,
G.