Skip to content

Commit 0b244fe

Browse files
authored
Chore/fix chromedriver again (#1004)
* Upgrade all Yarn deps in Test folders * Migrate to webdrivers gem * Revert Bundle Renderer test to before #792 Add pry-byebug for ease of debugging. Update the locally used react_ujs to 2.5.0 * Use travis recommended chrome config
1 parent 24816cb commit 0b244fe

File tree

12 files changed

+13599
-6505
lines changed

12 files changed

+13599
-6505
lines changed

.pryrc

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
if defined?(PryByebug)
2+
Pry.commands.alias_command 's', 'step'
3+
Pry.commands.alias_command 'n', 'next'
4+
Pry.commands.alias_command 'f', 'finish'
5+
Pry.commands.alias_command 'c', 'continue'
6+
end

.travis.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,5 +77,4 @@ before_install:
7777
- sudo apt-get update -qq
7878
- sudo apt-get install -y -qq yarn
7979
- gem update --system
80-
- gem install chromedriver-helper
81-
- chromedriver-update
80+
- google-chrome-stable --headless --disable-gpu --remote-debugging-port=9222 http://localhost &

Rakefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ end
8484
task default: :test
8585

8686
task :test_setup do
87+
load 'webdrivers/Rakefile'
8788
Dir.chdir('./test/dummy_sprockets') do
8889
`yarn install`
8990
end

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@
1414
"webpack": "^2.3.3"
1515
},
1616
"dependencies": {
17-
"react_ujs": "^2.4.4"
17+
"react_ujs": "^2.5.0"
1818
}
1919
}

react-rails.gemspec

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,12 @@ Gem::Specification.new do |s|
2323
s.add_development_dependency 'guard-minitest'
2424
s.add_development_dependency 'jbuilder'
2525
s.add_development_dependency 'listen', '~> 3.0.0' # support Ruby 2.1
26-
s.add_development_dependency 'chromedriver-helper'
26+
s.add_development_dependency 'webdrivers'
2727
s.add_development_dependency 'capybara'
2828
s.add_development_dependency 'selenium-webdriver'
2929
s.add_development_dependency 'test-unit', '~> 2.5'
3030
s.add_development_dependency 'rails', '>= 3.2'
31+
s.add_development_dependency 'pry-byebug'
3132

3233
s.add_dependency 'connection_pool'
3334
s.add_dependency 'execjs'

0 commit comments

Comments
 (0)