Adding example about how to disabling automatic unmounting component #121
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| `react_ujs` will also scan DOM elements and call `React.unmountComponentAtNode` on page unload. If you want to disable this behavior (if you are not using Turbolinks), remove `data-react-class` attribute in `componentDidMount`: | ||
|
|
||
| ```js | ||
| var MyComponent = React.createClass({ |
There was a problem hiding this comment.
I'm not a huge fan of this hack as a whole but while it exists let's make the example even clearer. Can we call it MyRootComponent or something similar so it's clear that this doesn't work for components at arbitrary depth. There's a danger there as in theory a component shouldn't know if it's the top-most since you could render the same component as a child elsewhere. But I suppose that's probably not what most people are doing so let's just make it as clear as possible.
There was a problem hiding this comment.
@zpao Good point. Done!
|
Thanks for a tip ) |
|
For non-Turbolinks settings, this has been disabled by default (since #318) |
Adding an example for who don't want components being unmounted.