Skip to content

Add documentation for controller component rendering #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2015

Conversation

garbles
Copy link
Contributor

@garbles garbles commented Sep 1, 2015

As per discussion in the pull request for this feature. :neckbeard:

/cc @rmosolgo

@borisrorsvort
Copy link
Contributor

Maybe we should say if there is a layout option or not 😉

@garbles
Copy link
Contributor Author

garbles commented Sep 1, 2015

@borisrorsvort thought about that, but stating The component will be rendered in place of yield. is probably clear enough. As a renderer, it accepts all of the usual options for rendering a view including layout.

Could change this to The component will be rendered in place of yield in the layout if we think that it makes things slightly more clear.

@borisrorsvort
Copy link
Contributor

Or "it behaves the same as normal render and his usual options"

@rmosolgo
Copy link
Member

rmosolgo commented Sep 3, 2015

^^ I agree, signaling that "normal" render options still work would be a good addition

@rmosolgo
Copy link
Member

@garbles if/when you get a chance to update this, go ahead and remove the note about ~>1.3.0. I'll cut a new version after merging, so I don't think it'll be necessary

@garbles garbles force-pushed the controller-rendering-readme branch from 06286e3 to 097407d Compare September 13, 2015 00:31
@garbles
Copy link
Contributor Author

garbles commented Sep 13, 2015

@rmosolgo @borisrorsvort thanks for the bump. I've pushed an update.

@garbles garbles force-pushed the controller-rendering-readme branch 4 times, most recently from e712d9a to 6d4e722 Compare September 14, 2015 13:32
rmosolgo pushed a commit that referenced this pull request Sep 15, 2015
Add documentation for controller component rendering
@rmosolgo rmosolgo merged commit d25c7b4 into reactjs:master Sep 15, 2015
@rmosolgo
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants