Skip to content

Commit 20fdca5

Browse files
committed
Forward android-arch form build-script to build-script-impl in case of i686, x86_64
1 parent 4aed033 commit 20fdca5

File tree

5 files changed

+16
-3
lines changed

5 files changed

+16
-3
lines changed

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -736,7 +736,7 @@ if(swift_build_android AND NOT "${SWIFT_ANDROID_NDK_PATH}" STREQUAL "")
736736
endif()
737737

738738
if("${SWIFT_SDK_ANDROID_ARCHITECTURES}" STREQUAL "")
739-
set(SWIFT_SDK_ANDROID_ARCHITECTURES armv7;aarch64)
739+
set(SWIFT_SDK_ANDROID_ARCHITECTURES armv7;aarch64;x86_64)
740740
endif()
741741
configure_sdk_unix("Android" "${SWIFT_SDK_ANDROID_ARCHITECTURES}")
742742
endif()

utils/build-presets.ini

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -808,6 +808,13 @@ android-icu-i18n=%(icu_dir)s/libicui18nswift.so
808808
android-icu-i18n-include=%(icu_dir)s/icu/source/i18n
809809
android-icu-data=%(icu_dir)s/libicudataswift.so
810810

811+
[preset: buildbot_linux_crosscompile_android,tools=RA,stdlib=RD,build,armv7]
812+
mixin-preset=buildbot_linux_crosscompile_android,tools=RA,stdlib=RD,build
813+
814+
dash-dash
815+
816+
android-arch=armv7
817+
811818
[preset: buildbot_linux_crosscompile_android,tools=RA,stdlib=RD,build,aarch64]
812819
mixin-preset=buildbot_linux_crosscompile_android,tools=RA,stdlib=RD,build
813820

utils/build-script

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -300,6 +300,12 @@ class BuildScriptInvocation(object):
300300
elif args.android_arch == "aarch64":
301301
args.stdlib_deployment_targets.append(
302302
StdlibDeploymentTarget.Android.aarch64.name)
303+
elif args.android_arch == "i686":
304+
args.stdlib_deployment_targets.append(
305+
StdlibDeploymentTarget.Android.i686.name)
306+
elif args.android_arch == "x86_64":
307+
args.stdlib_deployment_targets.append(
308+
StdlibDeploymentTarget.Android.x86_64.name)
303309

304310
# Infer platform flags from manually-specified configure targets.
305311
# This doesn't apply to Darwin platforms, as they are

utils/build_swift/driver_arguments.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -922,7 +922,7 @@ def create_argument_parser():
922922
android.adb.commands.DEVICE_TEMP_DIR))
923923

924924
option('--android-arch', store,
925-
choices=['armv7', 'aarch64'],
925+
choices=['armv7', 'aarch64', "i686", "x86_64"],
926926
default='armv7',
927927
help='The Android target architecture when building for Android. '
928928
'Currently only armv7 and aarch64 are supported. '

utils/swift_build_support/swift_build_support/targets.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ class StdlibDeploymentTarget(object):
125125

126126
Cygwin = Platform("cygwin", archs=["x86_64"])
127127

128-
Android = Platform("android", archs=["armv7", "aarch64"])
128+
Android = Platform("android", archs=["armv7", "aarch64", "i686", "x86_64"])
129129

130130
Windows = Platform("windows", archs=["x86_64"])
131131

0 commit comments

Comments
 (0)