Skip to content

Commit 7e97438

Browse files
committed
[SYCL][Doc] Rephrase "recording to"
[Review feedback](intel#5626 (comment)) questioned the phrase "graph is currently being recorded to" as to whether "to" should be "too". I don't think it should be "too", but rephrasing to "graph is currently recording any queues" avoids any confusion. Also updated the contributors to add Maxime and Jaime (who made the comment).
1 parent 498686c commit 7e97438

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

sycl/doc/extensions/proposed/sycl_ext_oneapi_graph.asciidoc

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ Guo Yejun, Intel +
4141
Dan Holmes, Intel +
4242
Greg Lueck, Intel +
4343
Steffen Larsen, Intel +
44+
Jaime Arteaga Molina, Intel +
4445
Ewan Crawford, Codeplay +
4546
Ben Tracy, Codeplay +
4647
Duncan McBain, Codeplay +
@@ -50,6 +51,7 @@ Gordon Brown, Codeplay +
5051
Erik Tomusk, Codeplay +
5152
Bjoern Knafla, Codeplay +
5253
Lukas Sommer, Codeplay +
54+
Maxime France-Pillois, Codeplay +
5355
Ronan Keryell, AMD +
5456

5557
== Dependencies
@@ -169,13 +171,13 @@ what data is internal to the graph for optimization, and dependencies don't need
169171
to be inferred.
170172

171173
It is valid to combine these two mechanisms, however it is invalid to modify
172-
a graph using the explicit API while that graph is currently being recorded to,
173-
for example:
174+
a graph using the explicit API while that graph is currently recording commands
175+
from any queue, for example:
174176

175177
[source, c++]
176178
----
177179
graph.begin_recording(queue);
178-
graph.add(/*command group*/); // Invalid as graph is being recorded to
180+
graph.add(/*command group*/); // Invalid as graph is recording a queue
179181
graph.end_recording();
180182
----
181183

0 commit comments

Comments
 (0)