feat: Add support for VS Code 1.89.x (#1293)

Signed-off-by: Dominik Jelinek <[email protected]>

Author: djelinek

.github/workflows/main.yml

@@ -17,7 +17,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        version: [ min, 1.87.2, max ]
+        version: [ min, 1.88.1, max ]
     uses: ./.github/workflows/template-main.yaml
     with:
       version: ${{ matrix.version }}

README.md

@@ -8,7 +8,7 @@
   <a href="https://www.npmjs.com/package/@redhat-developer/page-objects"><img src="https://img.shields.io/npm/v/@redhat-developer/page-objects?color=orange&label=page%20objects&style=for-the-badge&logo=npm" alt="ExTester Page Objects"/></a>
   <a href="https://github.com/redhat-developer/vscode-extension-tester/blob/main/LICENSE"><img src="https://img.shields.io/badge/license-Apache%202-yellow.svg?style=for-the-badge&logo=appveyor" alt="License"/></a>
   </br>
-  <a href="https://code.visualstudio.com"><img src="https://img.shields.io/badge/VS_Code-1.88.x-blue?style=for-the-badge&logo=visualstudiocode" alt="Maximal supported version of VS Code"></a>
+  <a href="https://code.visualstudio.com"><img src="https://img.shields.io/badge/VS_Code-1.89.x-blue?style=for-the-badge&logo=visualstudiocode" alt="Maximal supported version of VS Code"></a>
   <a href="https://github.com/redhat-developer/vscode-extension-tester/actions/workflows/main.yml"><img src="https://img.shields.io/github/actions/workflow/status/redhat-developer/vscode-extension-tester/main.yml?label=Main%20CI&style=for-the-badge&logo=githubactions" alt="Main CI"></a>
   <a href="https://github.com/redhat-developer/vscode-extension-tester/actions/workflows/insiders.yml"><img src="https://img.shields.io/github/actions/workflow/status/redhat-developer/vscode-extension-tester/insiders.yml?branch=main&label=Insider%20CI&style=for-the-badge&logo=githubactions" alt="Insider CI"></a>
 </p><br/>
@@ -39,7 +39,7 @@
 
 |NodeJS|Visual Studio Code|Operating System|
 |--|--|--|
-|<table style="text-align:center;"> <tr><th>18.x.x</th><th>LTS</th><th>Latest</th></tr><tr><td>✅</td><td>❓</td><td>❓</td></tr><tr><td colspan="3">❓ Best-effort</td></tr> </table>| <table style="text-align:center;"> <tr><th>min</th><th>-</th><th>max</th></tr><tr><td>1.86.x</td><td>1.87.x</td><td>1.88.x</td></tr> </table>| <table style="text-align:center;"> <tr><th>Linux</th><th>Windows</th><th>macOS</th></tr><tr><td>✅</td><td>✅</td><td>⚠️</td></tr><tr><td colspan="3">⚠️ [Known Issues](KNOWN_ISSUES.md#macos-known-limitations-of-native-objects)</td></tr> </table>|
+|<table style="text-align:center;"> <tr><th>18.x.x</th><th>LTS</th><th>Latest</th></tr><tr><td>✅</td><td>❓</td><td>❓</td></tr><tr><td colspan="3">❓ Best-effort</td></tr> </table>| <table style="text-align:center;"> <tr><th>min</th><th>-</th><th>max</th></tr><tr><td>1.87.x</td><td>1.88.x</td><td>1.89.x</td></tr> </table>| <table style="text-align:center;"> <tr><th>Linux</th><th>Windows</th><th>macOS</th></tr><tr><td>✅</td><td>✅</td><td>⚠️</td></tr><tr><td colspan="3">⚠️ [Known Issues](KNOWN_ISSUES.md#macos-known-limitations-of-native-objects)</td></tr> </table>|
 
 #### NodeJS Support Policy
 

packages/extester/package.json

@@ -52,8 +52,8 @@
     "ui-test"
   ],
   "supportedVersions": {
-    "vscode-min": "1.86.2",
-    "vscode-max": "1.88.1",
+    "vscode-min": "1.87.2",
+    "vscode-max": "1.89.0",
     "nodejs": "18"
   },
   "dependencies": {

packages/page-objects/src/components/sidebar/tree/debug/VariableSectionItem.ts

@@ -41,8 +41,12 @@ export class VariableSectionItem extends CustomTreeItem {
     /**
      * Get variable value tooltip.
      * @returns a promise resolving to variable value tooltip string
+     * @deprecated For VS Code 1.89+ this method won't be working any more
      */
     async getVariableValueTooltip(): Promise<string> {
+        if(VariableSectionItem.versionInfo.version >= '1.89.0') {
+            throw Error(`DEPRECATED METHOD! For VS Code 1.89+ this method won't be working any more.`);
+        }
         const value = await this.findElement(VariableSectionItem.locators.VariableSectionItem.value.constructor);
         return VariableSectionItem.locators.VariableSectionItem.value.tooltip(value);
     }

tests/test-project/src/test/debug/debug.test.ts

@@ -204,6 +204,9 @@ describe('Debugging', function () {
         });
 
         it('VariableSectionItem.getVariableValueTooltip', async function () {
+            if(VSBrowser.instance.version >= '1.89.0') {
+                this.skip();
+            }
             const item = await getNumVariable(view, this.timeout() - 2000);
             expect(await item?.getVariableValueTooltip()).equals('5');
         });

tests/test-project/src/test/editor/settingsEditor.test.ts

@@ -73,6 +73,7 @@ describe('Settings Editor', function () {
         });
 
         it('getDescription works', async function () {
+            setting = await editor.findSetting('Title Bar Style', 'Window') as ComboSetting;
             const desc = await setting.getDescription();
             expect(desc).not.empty;
         });