messaging properly when missing properites in validation

Author: slorello89

.github/images/autoscaler-architecture.png

@@ -0,0 +1,28 @@
+package com.redis.autoscaler;
+
+import org.springframework.http.HttpEntity;
+import org.springframework.http.HttpStatus;
+import org.springframework.http.ResponseEntity;
+import org.springframework.web.bind.MethodArgumentNotValidException;
+import org.springframework.web.bind.annotation.ControllerAdvice;
+import org.springframework.web.bind.annotation.ExceptionHandler;
+
+import java.util.HashMap;
+import java.util.Map;
+
+@ControllerAdvice
+public class ValidationExceptionHandler {
+
+    @ExceptionHandler(MethodArgumentNotValidException.class)
+    public ResponseEntity<Map<String,String>> failedValidation(MethodArgumentNotValidException ex) {
+
+        Map<String, String> errors = new HashMap<>();
+        errors.put("message", ex.getMessage());
+        errors.put("status", String.valueOf(HttpStatus.BAD_REQUEST.value()));
+
+        ex.getBindingResult().getFieldErrors().forEach(error ->
+                errors.put(error.getField(), error.getDefaultMessage())
+        );
+        return new ResponseEntity<>(errors, HttpStatus.BAD_REQUEST);
+    }
+}

.idea/uiDesigner.xml

@@ -5,6 +5,7 @@
 import com.redis.autoscaler.documents.TriggerType;
 import com.redis.autoscaler.services.RedisCloudDatabaseService;
 import com.redis.autoscaler.services.SchedulingService;
+import jakarta.validation.Valid;
 import org.slf4j.Logger;
 import org.springframework.http.HttpEntity;
 import org.springframework.http.HttpStatus;
@@ -36,7 +37,7 @@ public HttpEntity<Integer> getNumDatabases() throws IOException, InterruptedExce
 
 
     @PostMapping
-    public HttpEntity<Object> createRule(@RequestBody Rule rule) {
+    public HttpEntity<Object> createRule(@Valid @RequestBody Rule rule) {
         LOG.info("Received request to create rule: {}", rule);
 
         String ruleValidityError = rule.getValidationError();

autoscaler/redis-cloud-autoscaler/src/main/java/com/redis/autoscaler/ValidationExceptionHandler.java

@@ -1,7 +1,9 @@
 package com.redis.autoscaler.documents;
 
+import com.fasterxml.jackson.annotation.JsonProperty;
 import com.redis.om.spring.annotations.Document;
 import com.redis.om.spring.annotations.Indexed;
+import jakarta.validation.constraints.NotNull;
 import lombok.Data;
 import org.slf4j.Logger;
 import org.springframework.data.annotation.Id;
@@ -12,31 +14,41 @@ public class Rule {
     private static final Logger LOG = org.slf4j.LoggerFactory.getLogger(Rule.class);
 
     @Indexed
-    protected String dbId;
+    @Id
+    private String ruleId;
 
+    @JsonProperty(required = true)
     @Indexed
-    @Id
-    protected String ruleId;
+    private String dbId;
 
     @Indexed
-    protected RuleType ruleType;
+    @JsonProperty(required = true)
+    @NotNull(message = "ruleType is required")
+    private RuleType ruleType;
 
     @Indexed
-    protected ScaleType scaleType;
+    @JsonProperty(required = true)
+    @NotNull(message = "scaleType is required")
+    private ScaleType scaleType;
 
     @Indexed
-    protected TriggerType triggerType;
+    @JsonProperty(required = true)
+    @NotNull(message = "triggerType is required")
+    private TriggerType triggerType;
+
+    private String triggerValue;
 
-    protected String triggerValue;
+    @JsonProperty(required = true)
+    @NotNull(message = "scaleValue is required")
+    private double scaleValue;
 
-    protected double scaleValue;
-    protected double scaleCeiling;
-    protected double scaleFloor;
+    private double scaleCeiling;
+    private double scaleFloor;
 
     @Override
     public String toString(){
-        return String.format("Rule: dbId=%s, ruleId=%s, ruleType=%s, scaleType=%s, scaleValue=%f, scaleCeiling=%f, scaleFloor=%f",
-                dbId, ruleId, ruleType, scaleType, scaleValue, scaleCeiling, scaleFloor);
+        return String.format("Rule: dbId=%s, ruleId=%s, ruleType=%s, scaleType=%s, scaleValue=%f, scaleCeiling=%f, scaleFloor=%f, triggerType=%s, triggerValue=%s",
+                dbId, ruleId, ruleType, scaleType, scaleValue, scaleCeiling, scaleFloor, triggerType, triggerValue);
     }
 
 
@@ -92,7 +104,7 @@ public String getValidationError(){
         return "";
     }
 
-    protected boolean isMultipleOfPointOne() {
+    private boolean isMultipleOfPointOne() {
         LOG.info("Validating scale value: {}", scaleValue);
         double compValue = scaleValue - Math.floor(scaleValue);
         double epsilon = 1e-9; // Small tolerance for floating-point precision

autoscaler/redis-cloud-autoscaler/src/main/java/com/redis/autoscaler/controllers/RulesController.java

@@ -1,6 +1,6 @@
 #!/bin/bash
 
 ./gradlew clean bootjar
-gcloud compute scp ./autoscaler/redis-cloud-autoscaler/build/libs/redis-cloud-autoscaler-0.0.2.jar autoscaler-vm:~/autoscaler.jar --zone=us-east1-b
+gcloud compute scp ./autoscaler/redis-cloud-autoscaler/build/libs/redis-cloud-autoscaler-0.0.3.jar autoscaler-vm:~/autoscaler.jar --zone=us-east1-b
 # run command to move the jar to /usr/local/bin/autoscaler.jar, change owner to autoscaler, and restart the autoscaler service
 gcloud compute ssh --zone=us-east1-b autoscaler-vm --command "sudo cp ~/autoscaler.jar /usr/local/bin/autoscaler.jar && sudo chown autoscaler:autoscaler /usr/local/bin/autoscaler.jar && sudo systemctl restart autoscaler"