Skip to content

Commit eda5816

Browse files
slorello89slorello89
authored
correcting unlink return type (#435)
1 parent 8007db4 commit eda5816

File tree

6 files changed

+30
-16
lines changed

6 files changed

+30
-16
lines changed

‎src/Redis.OM.Vectorizers.AllMiniLML6V2/Redis.OM.Vectorizers.AllMiniLML6V2.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
<ImplicitUsings>enable</ImplicitUsings>
66
<Nullable>enable</Nullable>
77
<RootNamespace>Redis.OM.Vectorizers.AllMiniLML6V2</RootNamespace>
8-
<PackageVersion>0.6.1</PackageVersion>
9-
<Version>0.6.1</Version>
10-
<PackageReleaseNotes>https://github.com/redis/redis-om-dotnet/releases/tag/v0.6.1</PackageReleaseNotes>
8+
<PackageVersion>0.7.0</PackageVersion>
9+
<Version>0.7.0</Version>
10+
<PackageReleaseNotes>https://github.com/redis/redis-om-dotnet/releases/tag/v0.7.0</PackageReleaseNotes>
1111
<Description>Sentence Vectorizer for Redis OM .NET using all-MiniLM-L6-v2</Description>
1212
<Title>Redis OM all-MiniLM-L6-v2 Vectorizers</Title>
1313
<Authors>Steve Lorello</Authors>

‎src/Redis.OM.Vectorizers.Resnet18/Redis.OM.Vectorizers.Resnet18.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
<ImplicitUsings>enable</ImplicitUsings>
55
<Nullable>enable</Nullable>
66
<RootNamespace>Redis.OM.Vectorizers.Resnet18</RootNamespace>
7-
<PackageVersion>0.6.1</PackageVersion>
8-
<Version>0.6.1</Version>
9-
<PackageReleaseNotes>https://github.com/redis/redis-om-dotnet/releases/tag/v0.6.1</PackageReleaseNotes>
7+
<PackageVersion>0.7.0</PackageVersion>
8+
<Version>0.7.0</Version>
9+
<PackageReleaseNotes>https://github.com/redis/redis-om-dotnet/releases/tag/v0.7.0</PackageReleaseNotes>
1010
<Description>Resnet 18 Vectorizers for Redis OM .NET.</Description>
1111
<Title>Redis OM Resnet 18 Vectorizers</Title>
1212
<Authors>Steve Lorello</Authors>

‎src/Redis.OM.Vectorizers/Redis.OM.Vectorizers.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
<ImplicitUsings>enable</ImplicitUsings>
66
<Nullable>enable</Nullable>
77
<RootNamespace>Redis.OM</RootNamespace>
8-
<PackageVersion>0.6.1</PackageVersion>
9-
<Version>0.6.1</Version>
10-
<PackageReleaseNotes>https://github.com/redis/redis-om-dotnet/releases/tag/v0.6.1</PackageReleaseNotes>
8+
<PackageVersion>0.7.0</PackageVersion>
9+
<Version>0.7.0</Version>
10+
<PackageReleaseNotes>https://github.com/redis/redis-om-dotnet/releases/tag/v0.7.0</PackageReleaseNotes>
1111
<Description>Core Vectorizers for Redis OM .NET.</Description>
1212
<Title>Redis OM Vectorizers</Title>
1313
<Authors>Steve Lorello</Authors>

‎src/Redis.OM/Redis.OM.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66
<RootNamespace>Redis.OM</RootNamespace>
77
<Nullable>enable</Nullable>
88
<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
9-
<PackageVersion>0.6.1</PackageVersion>
10-
<Version>0.6.1</Version>
11-
<PackageReleaseNotes>https://github.com/redis/redis-om-dotnet/releases/tag/v0.6.1</PackageReleaseNotes>
9+
<PackageVersion>0.7.0</PackageVersion>
10+
<Version>0.7.0</Version>
11+
<PackageReleaseNotes>https://github.com/redis/redis-om-dotnet/releases/tag/v0.7.0</PackageReleaseNotes>
1212
<Description>Object Mapping and More for Redis</Description>
1313
<Title>Redis OM</Title>
1414
<Authors>Steve Lorello</Authors>

‎src/Redis.OM/RedisCommands.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -740,31 +740,31 @@ public static async Task<IDictionary<string, RedisReply>> HGetAllAsync(this IRed
740740
/// <param name="connection">the connection.</param>
741741
/// <param name="key">the key to unlink.</param>
742742
/// <returns>the status.</returns>
743-
public static string Unlink(this IRedisConnection connection, string key) => connection.Execute("UNLINK", key);
743+
public static long Unlink(this IRedisConnection connection, string key) => connection.Execute("UNLINK", key);
744744

745745
/// <summary>
746746
/// Unlinks array of keys.
747747
/// </summary>
748748
/// <param name="connection">the connection.</param>
749749
/// <param name="keys">the keys to unlink.</param>
750750
/// <returns>the status.</returns>
751-
public static string Unlink(this IRedisConnection connection, string[] keys) => connection.Execute("UNLINK", keys);
751+
public static long Unlink(this IRedisConnection connection, string[] keys) => connection.Execute("UNLINK", keys);
752752

753753
/// <summary>
754754
/// Unlinks a key.
755755
/// </summary>
756756
/// <param name="connection">the connection.</param>
757757
/// <param name="key">the key to unlink.</param>
758758
/// <returns>the status.</returns>
759-
public static async Task<string> UnlinkAsync(this IRedisConnection connection, string key) => await connection.ExecuteAsync("UNLINK", key);
759+
public static async Task<long> UnlinkAsync(this IRedisConnection connection, string key) => await connection.ExecuteAsync("UNLINK", key);
760760

761761
/// <summary>
762762
/// Unlinks array of keys.
763763
/// </summary>
764764
/// <param name="connection">the connection.</param>
765765
/// <param name="keys">the keys to unlink.</param>
766766
/// <returns>the status.</returns>
767-
public static async Task<string> UnlinkAsync(this IRedisConnection connection, string[] keys) => await connection.ExecuteAsync("UNLINK", keys);
767+
public static async Task<long> UnlinkAsync(this IRedisConnection connection, string[] keys) => await connection.ExecuteAsync("UNLINK", keys);
768768

769769
/// <summary>
770770
/// Unlinks the key and then adds an updated value of it.

‎test/Redis.OM.Unit.Tests/CoreTests.cs

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -479,5 +479,19 @@ public async Task SearchTimeoutTest()
479479
var ex = await Assert.ThrowsAsync<Exception>(async () => await collection.Take(10000).ToListAsync());
480480
Assert.True(ex.Message.Equals("Encountered timeout when searching - check the duration of your query.") || ex.Message.Contains("Timeout limit was reached"));
481481
}
482+
483+
[Fact]
484+
public void TestUnlink()
485+
{
486+
string key1 = $"test:{Ulid.NewUlid()}";
487+
string key2 = $"test:{Ulid.NewUlid()}";
488+
var hostInfo = Environment.GetEnvironmentVariable("STANDALONE_HOST_PORT") ?? "localhost:6379";
489+
var provider = new RedisConnectionProvider($"redis://{hostInfo}");
490+
var connection = provider.Connection;
491+
var res = connection.Unlink(key1);
492+
Assert.Equal(0, res);
493+
connection.Execute("SET", key1, "bar");
494+
Assert.Equal(1,connection.Unlink(new []{key1, key2}));
495+
}
482496
}
483497
}

0 commit comments

Comments
 (0)