Skip to content

Commit 34c5177

Browse files
committed
fix review comments
1 parent fe93f41 commit 34c5177

File tree

2 files changed

+185
-171
lines changed

2 files changed

+185
-171
lines changed

redis/commands/graph/__init__.py

Lines changed: 9 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -44,25 +44,19 @@ def _refresh_labels(self):
4444
lbls = self.labels()
4545

4646
# Unpack data.
47-
self._labels = [None] * len(lbls)
48-
for i, l in enumerate(lbls):
49-
self._labels[i] = l[0]
47+
self._labels = [l[0] for _, l in enumerate(lbls)]
5048

5149
def _refresh_relations(self):
5250
rels = self.relationship_types()
5351

5452
# Unpack data.
55-
self._relationship_types = [None] * len(rels)
56-
for i, r in enumerate(rels):
57-
self._relationship_types[i] = r[0]
53+
self._relationship_types = [r[0] for _, r in enumerate(rels)]
5854

5955
def _refresh_attributes(self):
6056
props = self.property_keys()
6157

6258
# Unpack data.
63-
self._properties = [None] * len(props)
64-
for i, p in enumerate(props):
65-
self._properties[i] = p[0]
59+
self._properties = [p[0] for _, p in enumerate(props)]
6660

6761
def get_label(self, idx):
6862
"""
@@ -169,25 +163,19 @@ async def _refresh_labels(self):
169163
lbls = await self.labels()
170164

171165
# Unpack data.
172-
self._labels = [None] * len(lbls)
173-
for i, l in enumerate(lbls):
174-
self._labels[i] = l[0]
166+
self._labels = [l[0] for _, l in enumerate(lbls)]
175167

176168
async def _refresh_attributes(self):
177169
props = await self.property_keys()
178170

179171
# Unpack data.
180-
self._properties = [None] * len(props)
181-
for i, p in enumerate(props):
182-
self._properties[i] = p[0]
172+
self._properties = [p[0] for _, p in enumerate(props)]
183173

184174
async def _refresh_relations(self):
185175
rels = await self.relationship_types()
186176

187177
# Unpack data.
188-
self._relationship_types = [None] * len(rels)
189-
for i, r in enumerate(rels):
190-
self._relationship_types[i] = r[0]
178+
self._relationship_types = [r[0] for _, r in enumerate(rels)]
191179

192180
async def get_label(self, idx):
193181
"""
@@ -250,12 +238,12 @@ async def call_procedure(self, procedure, *args, read_only=False, **kwagrs):
250238
return await self.query(q, read_only=read_only)
251239

252240
async def labels(self):
253-
return ((await self.call_procedure("db.labels", read_only=True))).result_set
241+
return ((await self.call_procedure("DB.LABELS", read_only=True))).result_set
254242

255243
async def property_keys(self):
256-
return (await self.call_procedure("db.propertyKeys", read_only=True)).result_set
244+
return (await self.call_procedure("DB.PROPERTYKEYS", read_only=True)).result_set
257245

258246
async def relationship_types(self):
259247
return (
260-
await self.call_procedure("db.relationshipTypes", read_only=True)
248+
await self.call_procedure("DB.RELATIONSHIPTYPES", read_only=True)
261249
).result_set

0 commit comments

Comments
 (0)