Use correct redis url if not default when creating Connection

Author: kristjanvalur

tests/test_asyncio/conftest.py

@@ -253,3 +253,13 @@ async def __aexit__(self, exc_type, exc_inst, tb):
 
 def asynccontextmanager(func):
     return _asynccontextmanager(func)
+
+# helpers to get the connection arguments for this run
+@pytest.fixture()
+def redis_url(request):
+    return request.config.getoption("--redis-url")
+
+@pytest.fixture()
+def connect_args(request):
+    url =  request.config.getoption("--redis-url")
+    return parse_url(url)

tests/test_asyncio/test_connection.py

@@ -125,9 +125,11 @@ async def test_can_run_concurrent_commands(r):
     assert all(await asyncio.gather(*(r.ping() for _ in range(10))))
 
 
-async def test_connect_retry_on_timeout_error():
+async def test_connect_retry_on_timeout_error(connect_args):
     """Test that the _connect function is retried in case of a timeout"""
-    conn = Connection(retry_on_timeout=True, retry=Retry(NoBackoff(), 3))
+    conn = Connection(
+        retry_on_timeout=True, retry=Retry(NoBackoff(), 3), **connect_args
+    )
     origin_connect = conn._connect
     conn._connect = mock.AsyncMock()
 
@@ -200,7 +202,7 @@ async def test_connection_parse_response_resume(r: redis.Redis):
     [_AsyncRESP2Parser, _AsyncRESP3Parser, _AsyncHiredisParser],
     ids=["AsyncRESP2Parser", "AsyncRESP3Parser", "AsyncHiredisParser"],
 )
-async def test_connection_disconect_race(parser_class):
+async def test_connection_disconect_race(parser_class, connect_args):
     """
     This test reproduces the case in issue #2349
     where a connection is closed while the parser is reading to feed the
@@ -215,10 +217,9 @@ async def test_connection_disconect_race(parser_class):
     if parser_class == _AsyncHiredisParser and not HIREDIS_AVAILABLE:
         pytest.skip("Hiredis not available")
 
-    args = {}
-    args["parser_class"] = parser_class
+    connect_args["parser_class"] = parser_class
 
-    conn = Connection(**args)
+    conn = Connection(**connect_args)
 
     cond = asyncio.Condition()
     # 0 == initial

tests/test_asyncio/test_sentinel_managed_connection.py

@@ -10,11 +10,11 @@
 pytestmark = pytest.mark.asyncio
 
 
-async def test_connect_retry_on_timeout_error():
+async def test_connect_retry_on_timeout_error(connect_args):
     """Test that the _connect function is retried in case of a timeout"""
     connection_pool = mock.AsyncMock()
     connection_pool.get_master_address = mock.AsyncMock(
-        return_value=("localhost", 6379)
+        return_value=(connect_args["host"], connect_args["port"])
     )
     conn = SentinelManagedConnection(
         retry_on_timeout=True,