hotfix, bogus test case for discussion

Author: phryneas

etc/redux-toolkit.api.md

@@ -103,7 +103,7 @@ export function createAction<P = void, T extends string = string>(type: T): Payl
 export function createAction<PA extends PrepareAction<any>, T extends string = string>(type: T, prepareAction: PA): PayloadActionCreator<ReturnType<PA>['payload'], T, PA>;
 
 // @alpha (undocumented)
-export function createAsyncThunk<Returned, ThunkArg = void, ThunkApiConfig extends AsyncThunkConfig = {}>(type: string, payloadCreator: (arg: ThunkArg, thunkAPI: GetThunkAPI<ThunkApiConfig>) => Promise<Returned> | Returned | Promise<RejectWithValue<GetRejectValue<ThunkApiConfig>>> | RejectWithValue<GetRejectValue<ThunkApiConfig>>): ((arg: ThunkArg) => (dispatch: GetDispatch<ThunkApiConfig>, getState: () => GetState<ThunkApiConfig>, extra: GetExtra<ThunkApiConfig>) => Promise<PayloadAction<Returned, string, {
+export function createAsyncThunk<Returned, ThunkArg = void, ThunkApiConfig extends AsyncThunkConfig = {}>(type: string, payloadCreator: (arg: ThunkArg, thunkAPI: GetThunkAPI<ThunkApiConfig>) => Promise<Returned | RejectWithValue<GetRejectValue<ThunkApiConfig>>> | Returned | RejectWithValue<GetRejectValue<ThunkApiConfig>>): ((arg: ThunkArg) => (dispatch: GetDispatch<ThunkApiConfig>, getState: () => GetState<ThunkApiConfig>, extra: GetExtra<ThunkApiConfig>) => Promise<PayloadAction<Returned, string, {
     arg: ThunkArg;
     requestId: string;
 }, never> | PayloadAction<GetRejectValue<ThunkApiConfig> | undefined, string, {

package-lock.json

@@ -28,6 +28,7 @@
     "@types/json-stringify-safe": "^5.0.0",
     "@types/nanoid": "^2.1.0",
     "@types/node": "^10.14.4",
+    "axios": "^0.19.2",
     "console-testing-library": "^0.3.1",
     "eslint-config-react-app": "^5.0.1",
     "invariant": "^2.2.4",

package.json

@@ -120,9 +120,8 @@ export function createAsyncThunk<
     arg: ThunkArg,
     thunkAPI: GetThunkAPI<ThunkApiConfig>
   ) =>
-    | Promise<Returned>
+    | Promise<Returned | RejectWithValue<GetRejectValue<ThunkApiConfig>>>
     | Returned
-    | Promise<RejectWithValue<GetRejectValue<ThunkApiConfig>>>
     | RejectWithValue<GetRejectValue<ThunkApiConfig>>
 ) {
   type RejectedValue = GetRejectValue<ThunkApiConfig>

src/createAsyncThunk.ts

@@ -1,6 +1,9 @@
 import { createAsyncThunk, Dispatch, createReducer, AnyAction } from 'src'
 import { ThunkDispatch } from 'redux-thunk'
-import { unwrapResult } from 'src/createAsyncThunk'
+import { unwrapResult, SerializedError } from 'src/createAsyncThunk'
+
+import apiRequest, { AxiosError } from 'axios'
+import { IsAny } from 'src/tsHelpers'
 
 function expectType<T>(t: T) {
   return t
@@ -122,3 +125,67 @@ const defaultDispatch = (() => {}) as ThunkDispatch<{}, any, AnyAction>
     expectType<ReturnValue>(returned.payload)
   }
 })()
+
+// bogus testcase for discussion
+{
+  interface Call {
+    qwe: 'asd'
+  }
+  interface RootState {}
+
+  interface RejectedErrorPayload<T> {
+    data: T
+    error: string
+  }
+
+  interface ValidationErrorsResponse extends CallsResponse {}
+
+  interface CallsResponse {
+    data: Call[]
+  }
+
+  const fetchLiveCallsError = createAsyncThunk<
+    Call[],
+    string,
+    {
+      state: RootState
+      rejectValue: RejectedErrorPayload<ValidationErrorsResponse>
+    }
+  >('calls/fetchLiveCalls', async (organizationId, { rejectWithValue }) => {
+    try {
+      const {
+        data: { data }
+      } = await apiRequest.get<CallsResponse>(
+        `organizations/${organizationId}/calls/live/iwill404`
+      )
+      return data
+    } catch (err) {
+      let error: AxiosError = err // cast for access to AxiosError properties
+      return rejectWithValue({
+        error: 'just a test message',
+        data: error.response?.data
+      })
+    }
+  })
+
+  defaultDispatch(fetchLiveCallsError('asd')).then(result => {
+    if (fetchLiveCallsError.fulfilled.match(result)) {
+      //success
+      expectType<ReturnType<typeof fetchLiveCallsError['fulfilled']>>(result)
+      expectType<Call[]>(result.payload)
+    } else {
+      expectType<ReturnType<typeof fetchLiveCallsError['rejected']>>(result)
+      if (result.payload) {
+        // rejected with value
+        expectType<RejectedErrorPayload<ValidationErrorsResponse>>(
+          result.payload
+        )
+      } else {
+        // rejected by throw
+        expectType<undefined>(result.payload)
+        // result.error is `any`, because `miniSerializeError` currently returns any (if you pass in a non-object, it returns it and not a SerializedError)
+        expectType<IsAny<typeof result['error'], true, false>>(true)
+      }
+    }
+  })
+}