Skip to content

Commit 0f6db9c

Browse files
committed
Move datastrategy to a call-site param for staticHandler.query
1 parent 6111684 commit 0f6db9c

File tree

1 file changed

+19
-6
lines changed

1 file changed

+19
-6
lines changed

packages/router/router.ts

Lines changed: 19 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -409,6 +409,7 @@ export interface StaticHandler {
409409
requestContext?: unknown;
410410
skipLoaders?: boolean;
411411
skipLoaderErrorBubbling?: boolean;
412+
unstable_dataStrategy?: DataStrategyFunction;
412413
}
413414
): Promise<StaticHandlerContext | Response>;
414415
queryRoute(
@@ -2927,7 +2928,6 @@ export interface CreateStaticHandlerOptions {
29272928
* @deprecated Use `mapRouteProperties` instead
29282929
*/
29292930
detectErrorBoundary?: DetectErrorBoundaryFunction;
2930-
unstable_dataStrategy?: DataStrategyFunction;
29312931
mapRouteProperties?: MapRoutePropertiesFunction;
29322932
future?: Partial<StaticHandlerFutureConfig>;
29332933
}
@@ -2943,7 +2943,6 @@ export function createStaticHandler(
29432943

29442944
let manifest: RouteManifest = {};
29452945
let basename = (opts ? opts.basename : null) || "/";
2946-
let dataStrategyImpl = opts?.unstable_dataStrategy || defaultDataStrategy;
29472946
let mapRouteProperties: MapRoutePropertiesFunction;
29482947
if (opts?.mapRouteProperties) {
29492948
mapRouteProperties = opts.mapRouteProperties;
@@ -3007,11 +3006,13 @@ export function createStaticHandler(
30073006
requestContext,
30083007
skipLoaderErrorBubbling,
30093008
skipLoaders,
3009+
unstable_dataStrategy,
30103010
}: {
30113011
loadRouteIds?: string[];
30123012
requestContext?: unknown;
30133013
skipLoaderErrorBubbling?: boolean;
30143014
skipLoaders?: boolean;
3015+
unstable_dataStrategy?: DataStrategyFunction;
30153016
} = {}
30163017
): Promise<StaticHandlerContext | Response> {
30173018
let url = new URL(request.url);
@@ -3063,6 +3064,7 @@ export function createStaticHandler(
30633064
location,
30643065
matches,
30653066
requestContext,
3067+
unstable_dataStrategy || null,
30663068
loadRouteIds || null,
30673069
skipLoaderErrorBubbling === true,
30683070
skipLoaders === true,
@@ -3143,6 +3145,7 @@ export function createStaticHandler(
31433145
matches,
31443146
requestContext,
31453147
null,
3148+
null,
31463149
false,
31473150
false,
31483151
match
@@ -3181,6 +3184,7 @@ export function createStaticHandler(
31813184
location: Location,
31823185
matches: AgnosticDataRouteMatch[],
31833186
requestContext: unknown,
3187+
unstable_dataStrategy: DataStrategyFunction | null,
31843188
loadRouteIds: string[] | null,
31853189
skipLoaderErrorBubbling: boolean,
31863190
skipLoaders: boolean,
@@ -3198,6 +3202,7 @@ export function createStaticHandler(
31983202
matches,
31993203
routeMatch || getTargetMatch(matches, location),
32003204
requestContext,
3205+
unstable_dataStrategy,
32013206
loadRouteIds,
32023207
skipLoaderErrorBubbling,
32033208
skipLoaders,
@@ -3210,6 +3215,7 @@ export function createStaticHandler(
32103215
request,
32113216
matches,
32123217
requestContext,
3218+
unstable_dataStrategy,
32133219
loadRouteIds,
32143220
skipLoaderErrorBubbling,
32153221
routeMatch
@@ -3245,6 +3251,7 @@ export function createStaticHandler(
32453251
matches: AgnosticDataRouteMatch[],
32463252
actionMatch: AgnosticDataRouteMatch,
32473253
requestContext: unknown,
3254+
unstable_dataStrategy: DataStrategyFunction | null,
32483255
loadRouteIds: string[] | null,
32493256
skipLoaderErrorBubbling: boolean,
32503257
skipLoaders: boolean,
@@ -3272,7 +3279,8 @@ export function createStaticHandler(
32723279
[actionMatch],
32733280
matches,
32743281
isRouteRequest,
3275-
requestContext
3282+
requestContext,
3283+
unstable_dataStrategy
32763284
);
32773285
result = results[0];
32783286

@@ -3367,6 +3375,7 @@ export function createStaticHandler(
33673375
loaderRequest,
33683376
matches,
33693377
requestContext,
3378+
unstable_dataStrategy,
33703379
loadRouteIds,
33713380
skipLoaderErrorBubbling,
33723381
null,
@@ -3405,6 +3414,7 @@ export function createStaticHandler(
34053414
loaderRequest,
34063415
matches,
34073416
requestContext,
3417+
unstable_dataStrategy,
34083418
loadRouteIds,
34093419
skipLoaderErrorBubbling,
34103420
null
@@ -3427,6 +3437,7 @@ export function createStaticHandler(
34273437
request: Request,
34283438
matches: AgnosticDataRouteMatch[],
34293439
requestContext: unknown,
3440+
unstable_dataStrategy: DataStrategyFunction | null,
34303441
loadRouteIds: string[] | null,
34313442
skipLoaderErrorBubbling: boolean,
34323443
routeMatch: AgnosticDataRouteMatch | null,
@@ -3495,7 +3506,8 @@ export function createStaticHandler(
34953506
matchesToLoad,
34963507
matches,
34973508
isRouteRequest,
3498-
requestContext
3509+
requestContext,
3510+
unstable_dataStrategy
34993511
);
35003512

35013513
if (request.signal.aborted) {
@@ -3541,10 +3553,11 @@ export function createStaticHandler(
35413553
matchesToLoad: AgnosticDataRouteMatch[],
35423554
matches: AgnosticDataRouteMatch[],
35433555
isRouteRequest: boolean,
3544-
requestContext: unknown
3556+
requestContext: unknown,
3557+
unstable_dataStrategy: DataStrategyFunction | null
35453558
): Promise<DataResult[]> {
35463559
let results = await callDataStrategyImpl(
3547-
dataStrategyImpl,
3560+
unstable_dataStrategy || defaultDataStrategy,
35483561
type,
35493562
request,
35503563
matchesToLoad,

0 commit comments

Comments
 (0)