fix(remix-server-runtime): fix createCookieFactory with secrets set to undefined (#6056)

Co-authored-by: Michaël De Boey <[email protected]>

Author: atesgoral

packages/remix-server-runtime/__tests__/cookies-test.ts

@@ -142,6 +142,18 @@ describe("cookies", () => {
     expect(setCookie).not.toEqual(setCookie2);
   });
 
+  it("makes the default secrets to be an empty array", async () => {
+    let cookie = createCookie("my-cookie");
+
+    expect(cookie.isSigned).toBe(false);
+
+    let cookie2 = createCookie("my-cookie2", {
+      secrets: undefined,
+    });
+
+    expect(cookie2.isSigned).toBe(false);
+  });
+
   it("makes the default path of cookies to be /", async () => {
     let cookie = createCookie("my-cookie");
 

packages/remix-server-runtime/cookies.ts

@@ -86,8 +86,7 @@ export const createCookieFactory =
     unsign: UnsignFunction;
   }): CreateCookieFunction =>
   (name, cookieOptions = {}) => {
-    let { secrets, ...options } = {
-      secrets: [],
+    let { secrets = [], ...options } = {
       path: "/",
       sameSite: "lax" as const,
       ...cookieOptions,