Skip to content

Commit ccf63e2

Browse files
committed
Merge branch 'main' into release-next
2 parents fff84b5 + bc25528 commit ccf63e2

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

DEVELOPMENT.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
New releases should be created from release branches originating from the `dev` branch. When you are ready to begin the release process:
66

7-
- Make sure you've pulled all of the changes from GitHub for both `dev` and `main` branches.
7+
- Make sure you've pulled all the changes from GitHub for both `dev` and `main` branches.
88
- Check out the `dev` branch.
99
- Create a new release branch with the `release-` prefix (eg, `git checkout -b release-next`).
1010
- **IMPORTANT:** The `release-` prefix is important, as this is what triggers our GitHub CI workflow that will ultimately publish the release.
@@ -17,7 +17,7 @@ Changesets will do most of the heavy lifting for our releases. When changes are
1717

1818
- Ensure you are on the new `release-*` branch.
1919
- Enter Changesets pre-release mode using the `pre` tag: `yarn changeset pre enter pre`.
20-
- Commit the change and push the the `release-*` branch to GitHub.
20+
- Commit the change and push the `release-*` branch to GitHub.
2121
- Wait for the release workflow to finish. The Changesets action in the workflow will open a PR that will increment all versions and generate the changelogs.
2222
- Review the updated `CHANGELOG` files and make any adjustments necessary, then merge the PR into the `release-*` branch.
2323
- `find packages -name 'CHANGELOG.md' -mindepth 2 -maxdepth 2 -exec code {} \;`
@@ -30,27 +30,27 @@ You may need to make changes to a pre-release prior to publishing a final stable
3030
- Make whatever changes you need.
3131
- Create a new changeset: `yarn changeset`.
3232
- **IMPORTANT:** This is required even if you ultimately don't want to include these changes in the logs. Remember, changelogs can be edited prior to publishing, but the Changeset version script needs to see new changesets in order to create a new version.
33-
- Commit the changesets and push the the `release-*` branch to GitHub.
33+
- Commit the changesets and push the `release-*` branch to GitHub.
3434
- Wait for the release workflow to finish and the Changesets action to open its PR that will increment all versions.
3535
- Review the PR, make any adjustments necessary, and merge it into the `release-*` branch.
3636
- Once the PR is merged, the release workflow will publish the updated packages to npm.
3737

3838
### Publishing the stable release
3939

4040
- Exit Changesets pre-release mode: `yarn changeset pre exit`.
41-
- Commit the edited pre-release file along with any unpublished changesets, and push the the `release-*` branch to GitHub.
41+
- Commit the edited pre-release file along with any unpublished changesets, and push the `release-*` branch to GitHub.
4242
- Wait for the release workflow to finish. The Changesets action in the workflow will open a PR that will increment all versions and generate the changelogs for the stable release.
4343
- Review the updated `CHANGELOG` files and make any adjustments necessary.
4444
- We should remove the changelogs for all pre-releases ahead of publishing the stable version.
4545
- [TODO: We should automate this]
46-
- Prepare the github release notes
46+
- Prepare the GitHub release notes
4747
- Copy the relevant changelog entries from all packages into the Release Notes and adjust accordingly, matching the format used by prior releases
4848
- Merge the PR into the `release-*` branch.
4949
- Once the PR is merged, the release workflow will publish the updated packages to npm.
5050
- Once the release is published:
5151
- merge the `release-*` branch into `main` and push it up to GitHub
5252
- merge the `release-*` branch into `dev` and push it up to GitHub
53-
- Convert the `[email protected]` tag to a Release on Github with the name `v6.x.y`
53+
- Convert the `[email protected]` tag to a Release on GitHub with the name `v6.x.y`
5454

5555
### Hotfix releases
5656

contributors.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
- 0xEddie
22
- abdallah-nour
3+
- abeadam
34
- abhi-kr-2100
45
- AchThomas
56
- adamdotjs
@@ -139,6 +140,7 @@
139140
- markivancho
140141
- maruffahmed
141142
- marvinruder
143+
- mathpaquette
142144
- matt-harro
143145
- maxpou
144146
- mcansh

docs/routers/picking-a-router.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ ReactDOM.createRoot(document.getElementById("root")).render(
5757

5858
We recommend all web projects use [`createBrowserRouter`][createbrowserrouter].
5959

60-
It uses the full URL instead of the hash urls (`#this/stuff`) common in web apps before `window.pushState` was standardized. Full URLs are better for SEO, better for server rendering, and are just more compatible with the rest of the web platform.
60+
It uses the full URL instead of the hash urls (`#this/stuff`) common in web apps before `history.pushState` was standardized. Full URLs are better for SEO, better for server rendering, and are just more compatible with the rest of the web platform.
6161

6262
If you're hosting your app on a static file server, you'll need to configure it to send all requests to your `index.html` to avoid getting 404s.
6363

0 commit comments

Comments
 (0)