Skip to content

fix: <Match exactly> takes parent into account #4001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2016

Conversation

alisd23
Copy link
Contributor

@alisd23 alisd23 commented Oct 6, 2016

Provide fix and tests for #3938

Applied the same fix as in #3939, but added a couple tests to prove the case

@alisd23 alisd23 mentioned this pull request Oct 6, 2016
Copy link
Member

@timdorr timdorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timdorr timdorr added the bug label Oct 6, 2016
@timdorr timdorr added this to the v4.0.0 milestone Oct 6, 2016
@ryanflorence ryanflorence merged commit b60bcb3 into remix-run:v4 Oct 6, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants