remove Array.fromIterator + friends in favor of specialized functions in Iterator

Author: zth

src/Core__Array.res

@@ -10,9 +10,6 @@ external setUnsafe: (array<'a>, int, 'a) => unit = "%array_unsafe_set"
 @val
 external fromArrayLikeWithMap: (Js.Array2.array_like<'a>, 'a => 'b) => array<'b> = "Array.from"
 
-@val external fromIterator: Core__Iterator.t<'a> => array<'a> = "Array.from"
-@val external fromIteratorWithMap: (Core__Iterator.t<'a>, 'a => 'b) => array<'b> = "Array.from"
-
 @send external fillAllInPlace: (array<'a>, 'a) => unit = "fill"
 
 @send external fillInPlaceToEnd: (array<'a>, 'a, ~start: int) => unit = "fill"

src/Core__Array.resi

@@ -3,8 +3,6 @@
 @val external fromArrayLike: Js.Array2.array_like<'a> => array<'a> = "Array.from"
 @val
 external fromArrayLikeWithMap: (Js.Array2.array_like<'a>, 'a => 'b) => array<'b> = "Array.from"
-@val external fromIterator: Core__Iterator.t<'a> => array<'a> = "Array.from"
-@val external fromIteratorWithMap: (Core__Iterator.t<'a>, 'a => 'b) => array<'b> = "Array.from"
 
 /**
   `make(~length, init)`

src/Core__Iterator.res

@@ -6,4 +6,5 @@ type value<'a> = {
 }
 
 @send external next: t<'a> => value<'a> = "next"
-@scope("Array") external toArray: t<'a> => array<'a> = "from"
+external toArray: t<'a> => array<'a> = "Array.from"
+external toArrayWithMapper: (t<'a>, 'a => 'b) => array<'b> = "Array.from"

src/Core__Iterator.resi

@@ -55,5 +55,26 @@ let mapKeysAsArray = map->Map.keys->Iterator.toArray
 Console.log(mapKeysAsArray) // Logs ["someKey", "someKey2"] to the console.
 ```
 */
-@scope("Array")
-external toArray: t<'a> => array<'a> = "from"
+external toArray: t<'a> => array<'a> = "Array.from"
+
+/**
+Turns an iterator into an array of the remaining values, applying the provided mapper function on each item.
+Remember that each invocation of `next` of an iterator consumes a value. `Iterator.toArrayWithMapper` will consume all remaining values of the iterator and return them in an array to you.
+
+See [iterator protocols](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Iteration_protocols) on MDN.
+
+## Examples
+```rescript
+let map = Map.make()
+map->Map.set("someKey", "someValue")
+map->Map.set("someKey2", "someValue2")
+
+// `Map.keys` returns all keys of the map as an iterator.
+let mapKeysAsArray = map
+  ->Map.keys
+  ->Iterator.toArrayWithMapper(key => key->String.length)
+
+Console.log(mapKeysAsArray) // Logs [7, 8] to the console.
+```
+*/
+external toArrayWithMapper: (t<'a>, 'a => 'b) => array<'b> = "Array.from"

test/TempTests.res

@@ -171,7 +171,7 @@ Console.info("Symbol")
 Console.info("---")
 let x = Symbol.getFor("Foo")
 Console.log(x)
-let array: array<string> = Array.fromIterator(String.getSymbolUnsafe("foo", Symbol.iterator)(.))
+let array: array<string> = String.getSymbolUnsafe("foo", Symbol.iterator)(.)->Iterator.toArray
 Console.log(array)
 
 Console.info("")