Merge pull request #3137 from BuckleScript/more_tests_for_4.06

more tests to check 4.06 regression

Author: bobzhang

jscomp/core/lam_analysis.ml

@@ -59,6 +59,7 @@ let rec no_side_effects (lam : Lam.t) : bool =
 
             | "caml_create_string" (* TODO: add more *)
             | "caml_make_vect"
+            | "caml_create_bytes"
             | "caml_obj_dup"
             | "caml_array_dup"
             | "caml_obj_block"

jscomp/test/bs_min_max_test.js

@@ -82,6 +82,12 @@ eq("File \"bs_min_max_test.ml\", line 34, characters 5-12", Caml_obj.caml_max(un
 
 b("File \"bs_min_max_test.ml\", line 35, characters 4-11", Caml_obj.caml_greaterequal(5, undefined));
 
+b("File \"bs_min_max_test.ml\", line 36, characters 4-11", Caml_obj.caml_lessequal(undefined, 5));
+
+b("File \"bs_min_max_test.ml\", line 37, characters 4-11", true);
+
+b("File \"bs_min_max_test.ml\", line 38, characters 4-11", true);
+
 Mt.from_pair_suites("bs_min_max_test.ml", suites[0]);
 
 exports.suites = suites;

jscomp/test/bs_min_max_test.ml

@@ -32,6 +32,9 @@ let () =
   eq __LOC__ (f5_min (Some 3) None) None;
   eq __LOC__ (f5_max (Some 3) None) (Some 3);
   eq __LOC__ (f5_max None (Some 3) ) (Some 3);
-  b __LOC__ (Some 5 >= None) (*-FIXME 5 >= undefined*)
+  b __LOC__ (Some 5 >= None) ;
+  b __LOC__ (None <= Some 5);
+  b __LOC__ (not (None = Some 5));
+  b __LOC__ ( (None <> Some 5))
 
 ;; Mt.from_pair_suites __FILE__ !suites  

jscomp/test/caml_compare_test.js

@@ -5,17 +5,17 @@ let function_equal_test = try ((fun x -> x + 1) = (fun x -> x + 2)) with
                          | Invalid_argument "equal: functional value" -> true
                          | _ -> false
 
-let suites = Mt.[
-    __LOC__ , (fun _ -> Eq(true, None < Some 1)); (*-FIXME undefined < 1*)
+let suites = ref Mt.[
+    __LOC__ , (fun _ -> Eq(true, None < Some 1)); 
     "option2", (fun _ -> Eq(true, Some 1 < Some 2));
-    __LOC__, (fun _ -> Eq(true, [1] > [])); (*-FIXME Wrong specialization to [1] > 0 *)
+    __LOC__, (fun _ -> Eq(true, [1] > [])); 
     "listeq", (fun _ -> Eq(true, [1;2;3] = [1;2;3]));
     "listneq", (fun _ -> Eq(true, [1;2;3] > [1;2;2]));
     "custom_u", (fun _ -> Eq(true, ( A 3  ,  B (2,false) , C 1)  > ( A 3, B (2,false) , C 0 )));
     "custom_u2", (fun _ -> Eq(true, ( A 3  ,  B (2,false) , C 1)  = ( A 3, B (2,false) , C 1 )));
     "function", (fun _ -> Eq(true, function_equal_test));
     __LOC__ , begin fun _ -> 
-        Eq(true, None < Some 1) (*-FIXME*)
+        Eq(true, None < Some 1) 
     end;
     (*JS WAT 
         {[
@@ -26,10 +26,10 @@ let suites = Mt.[
         ]}
     *)
     __LOC__, begin fun _ -> 
-        Eq(true, None < Some [|1;30|] ) (*-FIXME *)
+        Eq(true, None < Some [|1;30|] )
     end; 
     __LOC__, begin fun _ -> 
-        Eq(true,  Some [|1;30|] > None  ) (*-FIXME*)
+        Eq(true,  Some [|1;30|] > None  ) 
     end; 
     __LOC__ , begin fun _ -> 
         Eq(true, [2;6;1;1;2;1;4;2;1] < [2;6;1;1;2;1;4;2;1;409])
@@ -38,7 +38,7 @@ let suites = Mt.[
         Eq(true, [1] < [1;409])
     end;
     __LOC__ , begin fun _ -> 
-        Eq(true, [] < [409]) (*-FIXME*)
+        Eq(true, [] < [409]) 
     end;
     __LOC__ , begin fun _ -> 
         Eq(true,  [2;6;1;1;2;1;4;2;1;409] > [2;6;1;1;2;1;4;2;1])
@@ -106,5 +106,12 @@ let suites = Mt.[
 ;;
 
 
+let test_id = ref 0
+let eq loc x y = Mt.eq_suites ~test_id ~suites loc x y 
 
-Mt.from_pair_suites __FILE__ suites
+;; eq __LOC__ true (Some 1 > None)
+;; eq __LOC__ true ([] < [1])
+;; eq __LOC__ false (None > Some 1)
+;; eq __LOC__ false (None > Some [|1;30|])
+;; eq __LOC__ false (Some [|1;30|] < None)
+let () = Mt.from_pair_suites __FILE__ !suites

jscomp/test/caml_compare_test.ml

@@ -128,5 +128,5 @@ let suites = [];;
 let suites = 
   Mt.[ "should raise", fun _ -> ThrowAny (fun _ -> test args2)]
 #end
-;; Mt.from_pair_suites __FILE__ suites
+let () =  Mt.from_pair_suites __FILE__ suites
 

jscomp/test/libarg_test.ml

@@ -120,7 +120,13 @@ function f13$1(param) {
 
 b("File \"option_repr_test.ml\", line 94, characters 4-11", Caml_obj.caml_lessthan(undefined, null));
 
-b("File \"option_repr_test.ml\", line 95, characters 4-11", Caml_obj.caml_lessthan(undefined, Js_primitive.some(undefined)));
+b("File \"option_repr_test.ml\", line 95, characters 4-11", !Caml_obj.caml_greaterthan(undefined, null));
+
+b("File \"option_repr_test.ml\", line 96, characters 4-11", Caml_obj.caml_greaterthan(null, undefined));
+
+b("File \"option_repr_test.ml\", line 97, characters 4-11", Caml_obj.caml_lessthan(undefined, Js_primitive.some(undefined)));
+
+b("File \"option_repr_test.ml\", line 98, characters 4-11", Caml_obj.caml_greaterthan(Js_primitive.some(undefined), undefined));
 
 console.log(6, undefined);
 
@@ -169,7 +175,7 @@ var xs = /* :: */[
   /* [] */0
 ];
 
-b("File \"option_repr_test.ml\", line 118, characters 5-12", Belt_List.every(xs, (function (x) {
+b("File \"option_repr_test.ml\", line 121, characters 5-12", Belt_List.every(xs, (function (x) {
             return x;
           })));
 
@@ -214,7 +220,7 @@ var xs$1 = /* :: */[
   xs_001
 ];
 
-b("File \"option_repr_test.ml\", line 124, characters 5-12", Belt_List.every(xs$1, (function (x) {
+b("File \"option_repr_test.ml\", line 127, characters 5-12", Belt_List.every(xs$1, (function (x) {
             return x;
           })));
 
@@ -239,7 +245,7 @@ var xs$2 = /* :: */[
   xs_001$1
 ];
 
-b("File \"option_repr_test.ml\", line 140, characters 5-12", Belt_List.every(xs$2, (function (x) {
+b("File \"option_repr_test.ml\", line 143, characters 5-12", Belt_List.every(xs$2, (function (x) {
             return x;
           })));
 

jscomp/test/option_repr_test.js

@@ -91,9 +91,12 @@ let f13 () =
 
 
 let () =   
-  b __LOC__ (None < Some Js.null); (*-FIXME*)
-  b __LOC__ (None < Some Js.undefined)
-  (*-FIXME always do commute tests to have a higher coverage *)
+  b __LOC__ (None < Some Js.null); 
+  b __LOC__ (not (None > Some Js.null)); 
+  b __LOC__ ( ( Some Js.null > None)); 
+  b __LOC__ (None < Some Js.undefined);
+  b __LOC__ ( Some Js.undefined > None);
+  
 external log3 :
   req:([ `String of string
        | `Int of int

jscomp/test/option_repr_test.ml

@@ -86711,6 +86711,7 @@ let rec no_side_effects (lam : Lam.t) : bool =
 
             | "caml_create_string" (* TODO: add more *)
             | "caml_make_vect"
+            | "caml_create_bytes"
             | "caml_obj_dup"
             | "caml_array_dup"
             | "caml_obj_block"