File tree Expand file tree Collapse file tree 1 file changed +1
-6
lines changed Expand file tree Collapse file tree 1 file changed +1
-6
lines changed Original file line number Diff line number Diff line change @@ -103,12 +103,7 @@ let rec no_side_effect_expression_desc (x : J.expression_desc) =
103
103
| String_append (a , b ) | Seq (a , b ) -> no_side_effect a && no_side_effect b
104
104
| Length (e , _ ) | Caml_block_tag (e , _ ) | Typeof e -> no_side_effect e
105
105
| Bin (op , a , b ) -> op <> Eq && no_side_effect a && no_side_effect b
106
- (*
107
- TODO: we should check look at each of the expressions in the 'values' list/array
108
- to determine if any of them have side-effects. For now we'll just return false
109
- to make the compiler happy.
110
- *)
111
- | Tagged_template _ -> false
106
+ | Tagged_template (_call_expr , _strings , values ) -> Ext_list. for_all values no_side_effect
112
107
| Js_not _ | Cond _ | FlatCall _ | Call _ | New _ | Raw_js_code _
113
108
(* actually true? *) ->
114
109
false
You can’t perform that action at this time.
0 commit comments