Skip to content

Commit 877b835

Browse files
committed
createElement not variadic
1 parent 55eacb9 commit 877b835

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed

jscomp/syntax/src/reactjs_jsx_v4.ml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1388,11 +1388,7 @@ let expr ~config mapper expression =
13881388
Exp.ident ~loc {loc; txt = Ldot (Lident "React", "jsxs")}
13891389
else Exp.ident ~loc {loc; txt = Ldot (Lident "React", "jsx")}
13901390
| "classic" | _ ->
1391-
if countOfChildren childrenExpr > 1 then
1392-
Exp.ident ~loc
1393-
{loc; txt = Ldot (Lident "React", "createElementVariadic")}
1394-
else
1395-
Exp.ident ~loc {loc; txt = Ldot (Lident "React", "createElement")})
1391+
Exp.ident ~loc {loc; txt = Ldot (Lident "React", "createElement")})
13961392
args)
13971393
(* Delegate to the default mapper, a deep identity traversal *)
13981394
| e -> default_mapper.expr mapper e

jscomp/syntax/tests/ppx/react/expected/fragment.res.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ let _ = React.createElement(
55
React.fragment,
66
{children: ReactDOM.createDOMElementVariadic("div", [])},
77
)
8-
let _ = React.createElementVariadic(
8+
let _ = React.createElement(
99
React.fragment,
1010
{
1111
children: [

jscomp/syntax/tests/ppx/react/expected/noPropsWithKey.res.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ module V4C = {
2222
type props = {}
2323

2424
let make = (_: props) =>
25-
React.createElementVariadic(
25+
React.createElement(
2626
React.fragment,
2727
{
2828
children: [

jscomp/syntax/tests/ppx/react/expected/removedKeyProp.res.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ module HasChildren = {
2424
type props = {}
2525

2626
let make = (_: props) =>
27-
React.createElementVariadic(
27+
React.createElement(
2828
React.fragment,
2929
{
3030
children: [

0 commit comments

Comments
 (0)