record of children for fragment

Author: mununki

jscomp/syntax/src/reactjs_jsx_v4.ml

@@ -1364,17 +1364,14 @@ let expr ~config mapper expression =
       let args =
         [
           (nolabel, fragment);
-          (match config.mode with
-          | "automatic" -> (
-            ( nolabel,
-              match childrenExpr with
-              | {pexp_desc = Pexp_array children} -> (
-                match children with
-                | [] -> emptyRecord ~loc:Location.none
-                | [child] -> recordOfChildren child
-                | _ -> recordOfChildren childrenExpr)
-              | _ -> recordOfChildren childrenExpr ))
-          | "classic" | _ -> (nolabel, childrenExpr));
+          ( nolabel,
+            match childrenExpr with
+            | {pexp_desc = Pexp_array children} -> (
+              match children with
+              | [] -> emptyRecord ~loc:Location.none
+              | [child] -> recordOfChildren child
+              | _ -> recordOfChildren childrenExpr)
+            | _ -> recordOfChildren childrenExpr );
         ]
       in
       let countOfChildren = function

jscomp/syntax/tests/ppx/react/expected/fragment.res.txt

@@ -1,12 +1,20 @@
 @@jsxConfig({version: 4, mode: "classic"})
 
-let _ = React.createElement(React.fragment, [])
-let _ = React.createElement(React.fragment, [ReactDOM.createDOMElementVariadic("div", [])])
+let _ = React.createElement(React.fragment, {})
+let _ = React.createElement(
+  React.fragment,
+  {children: ReactDOM.createDOMElementVariadic("div", [])},
+)
 let _ = React.createElementVariadic(
   React.fragment,
-  [ReactDOM.createDOMElementVariadic("div", []), ReactDOM.createDOMElementVariadic("div", [])],
+  {
+    children: [
+      ReactDOM.createDOMElementVariadic("div", []),
+      ReactDOM.createDOMElementVariadic("div", []),
+    ],
+  },
 )
-let _ = React.createElement(React.fragment, [React.createElement(React.fragment, [])])
+let _ = React.createElement(React.fragment, {children: React.createElement(React.fragment, {})})
 let _ = React.createElement(Z.make, {})
 let _ = React.createElement(Z.make, {children: ReactDOM.createDOMElementVariadic("div", [])})
 let _ = React.createElementVariadic(

jscomp/syntax/tests/ppx/react/expected/noPropsWithKey.res.txt

@@ -24,10 +24,12 @@ module V4C = {
   let make = (_: props) =>
     React.createElementVariadic(
       React.fragment,
-      [
-        JsxPPXReactSupport.createElementWithKey(~key="k", V4CA.make, {}),
-        JsxPPXReactSupport.createElementWithKey(~key="k", V4CB.make, {}),
-      ],
+      {
+        children: [
+          JsxPPXReactSupport.createElementWithKey(~key="k", V4CA.make, {}),
+          JsxPPXReactSupport.createElementWithKey(~key="k", V4CB.make, {}),
+        ],
+      },
     )
   let make = {
     let \"NoPropsWithKey$V4C" = props => make(props)

jscomp/syntax/tests/ppx/react/expected/removedKeyProp.res.txt

@@ -14,7 +14,7 @@ module Foo = {
 module HasChildren = {
   type props<'children> = {children: 'children}
 
-  let make = ({children, _}: props<_>) => React.createElement(React.fragment, [children])
+  let make = ({children, _}: props<_>) => React.createElement(React.fragment, {children: children})
   let make = {
     let \"RemovedKeyProp$HasChildren" = (props: props<_>) => make(props)
 
@@ -26,23 +26,25 @@ type props = {}
 let make = (_: props) =>
   React.createElementVariadic(
     React.fragment,
-    [
-      JsxPPXReactSupport.createElementWithKey(~key="k", Foo.make, {x: "x", y: "y"}),
-      React.createElement(Foo.make, {x: "x", y: "y"}),
-      JsxPPXReactSupport.createElementWithKey(
-        ~key="k",
-        HasChildren.make,
-        {
-          children: React.createElement(Foo.make, {x: "x", y: "y"}),
-        },
-      ),
-      React.createElement(
-        HasChildren.make,
-        {
-          children: React.createElement(Foo.make, {x: "x", y: "y"}),
-        },
-      ),
-    ],
+    {
+      children: [
+        JsxPPXReactSupport.createElementWithKey(~key="k", Foo.make, {x: "x", y: "y"}),
+        React.createElement(Foo.make, {x: "x", y: "y"}),
+        JsxPPXReactSupport.createElementWithKey(
+          ~key="k",
+          HasChildren.make,
+          {
+            children: React.createElement(Foo.make, {x: "x", y: "y"}),
+          },
+        ),
+        React.createElement(
+          HasChildren.make,
+          {
+            children: React.createElement(Foo.make, {x: "x", y: "y"}),
+          },
+        ),
+      ],
+    },
   )
 let make = {
   let \"RemovedKeyProp" = props => make(props)